Closed Bug 632725 Opened 13 years ago Closed 13 years ago

[backend] Build a diff viewer for add-ons

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Product:
addons.mozilla.org Graveyard
Component:
Admin/Editor Tools
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clouserw, Assigned: andy+bugzilla)

References

Details

(Whiteboard: [patch][qa-]) 

This is very similar to the file viewer (bug 632719) but it actually diffs two versions of an add-on.  See an example here:

https://addons.allizom.org/en-US/firefox/files/diff/108581/

The same rules apply to this bug as the file viewer - extract to temp dir is fine, send etag and last-modified headers, and be aware of security issues.  Bonus things for this page though:

- Include a <meta> tag to deny robots from indexing the page (see the main site header for an example)

- The URL for this is pretty ugly.  github's structure is pretty cool, the /compare/$ver1...$ver2 is cool.  Just throwing that out there.
Blocks: 632726
Assignee: nobody → amckay
Target Milestone: Q1 2011 → 6.0.1
Target Milestone: 6.0.1 → 6.0.3
Whiteboard: [patch][qa-]
Target Milestone: 6.0.3 → 6.0.4
https://github.com/jbalogh/zamboni/commit/c79850a03ce3a44d3c6c2e807daa9dc86932da15
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.