632774 - generated source bookmarklet fails

Status: RESOLVED INVALID

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

bookmarklet from https://www.squarefree.com/bookmarklets/webdevel.html

When clicking the bookmarklet (I have it on the BM bar), it returns an html page instead of a plain text page with generated source.

ok - 20110201001851 -- changeset: ec378b316279
fails - 2011020200092 --changeset: 113dcfecad64

http://hg.mozilla.org/camino/pushloghtml?fromchange=ec378b316279&tochange=113dcfecad64

Comment 1

[philippe (part-time)]

bleh :-(
partially broken bookmarks file... once I made a fresh bookmark for the bookmarklet, it works correctly.

Comment 2

[Chris Lawson (gone)]

What was broken about the original bookmark and/or file? There might be something we need to fix anyway :)

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> What was broken about the original bookmark and/or file? There might be
> something we need to fix anyway :)

the url I had in the BM file:
javascript:(function()%7B%20function%20htmlEscape(s)%7Bs=s.replace(/&/g,'&');s=s.replace(/%3E/g,'%3E');s=s.replace(/%3C/g,'%3C');return%20s;%7D%20x=window.open();%20x.document.write('%3Cpre%3E'%20+%20htmlEscape('%3Chtml%3E%5Cn'%20+%20document.documentElement.innerHTML%20+%20'%5Cn%3C/html%3E'));%20x.document.close();%20%7D)();

The correct url 
javascript:(function()%7B%20function%20htmlEscape(s)%7Bs=s.replace(/&/g,'&');s=s.replace(/%3E/g,'>');s=s.replace(/%3C/g,'<');return%20s;%7D%20x=window.open();%20x.document.write('%3Cpre%3E'%20+%20htmlEscape('%3Chtml%3E%5Cn'%20+%20document.documentElement.innerHTML%20+%20'%5Cn%3C/html%3E'));%20x.document.close();%20%7D)();

(view that in a code eitor with syntax highlighting)
& instead of &
%3E instead of >
etc.

I'm not yet 100% sure, but I think it happens when exporting bookmarks and then importing. Investigating at the moment.