Mozilla does not compile anymore on arm-hardfp

RESOLVED WORKSFORME

Status

()

Core
Build Config
RESOLVED WORKSFORME
7 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
ARM
MeeGo
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Bug 632162 has been landed even with separate ARM_VFP define MOZ_ARM_VFP_FLAGS, but even with that we still have -mfloat-abi=softfp hardcoded
http://hg.mozilla.org/mozilla-central/annotate/280e978fc6fb//configure.in#l7225

CFLAGS="$CFLAGS -march=armv7-a -marm -mfloat-abi=softfp $MOZ_ARM_VFP_FLAGS"

I'm using hardfp toolchain arm.
sbox-arm-none-linux-gnueabi-g++ ('cs2009q3-hard-67-sb12') 4.4.1
This should IMHO be handled with bug 626035
(Assignee)

Comment 2

7 years ago
Created attachment 511109 [details] [diff] [review]
no hardcoded softfp flag
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #511109 - Flags: review?(vladimir)
(Assignee)

Comment 3

7 years ago
hmm I tried second patch in that bug and got another error:

checking for valid optimization flags... no
configure: error: These compiler flags are invalid: -Os -freorder-blocks -fomit-frame-pointer
(Assignee)

Comment 4

7 years ago
"alternative proposal" also  does not help with this problem (it does not solve that at all)
(In reply to comment #4)
> "alternative proposal" also  does not help with this problem (it does not solve
> that at all)

no, but the problem is that fiddling with build flags should be done in .mozconfig, not configure.in.
(Assignee)

Updated

6 years ago
Duplicate of this bug: 616413
(Assignee)

Updated

6 years ago
Depends on: 626035
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 626035
(Assignee)

Comment 8

6 years ago
Comment on attachment 511109 [details] [diff] [review]
no hardcoded softfp flag

obsolete
Attachment #511109 - Flags: review?(vladimir)
(Assignee)

Comment 9

6 years ago
Created attachment 526595 [details] [diff] [review]
Detect HRDFP in configure and disable softfp only in that case
Attachment #511109 - Attachment is obsolete: true
Attachment #526595 - Flags: review?(mh+mozilla)
(Assignee)

Comment 10

6 years ago
sounds like bug 626035 does not have good progress...
Can we apply this patch (it should be safe for maem/android) and not required any mozconfig changes
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment on attachment 526595 [details] [diff] [review]
Detect HRDFP in configure and disable softfp only in that case

I think what we need is a configure flag, e.g --with-arm-float-abi, passing its value to -mfloat-abi when there is one, and with appropriate defaults for the different platforms. This is the way forward for bug 626035 as well (comment 50).
Attachment #526595 - Flags: review?(mh+mozilla) → review-
I'm pretty sure this is not an issue anymore with the various changes that happened to the build system (and Debian packages do build fine on armhf)
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → WORKSFORME

Comment 13

6 years ago
looking at xulrunner 9 in Fedora all the options look to be there in configure to set all the various hard/soft and the type of FP unit.
You need to log in before you can comment on or make changes to this bug.