633000 - Implement Top Orange e-mail

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

As per previous discussions, we'd like to create some kind of Top Oranges e-mail which describes the top X oranges and their impact on the tree, and distribute it on a regular basis, with the goal of improving visibility of OrangeFactor and the top random oranges.

One idea would be to send this every week (probably Monday a.m. prior to the project-wide status meeting) to dev-planning.  Other ideas include linking to this report from the weekly update wiki, or including with the engineering newsletter.

We could also consider including in this e-mail a list of random oranges that were fixed in the previous week, along with the person who fixed it.

Comment 1

[Mark Côté [:mcote]]

Attachment: Script to mail top-bugs report

Here we go.  Needs a conf file named woo_mailer.conf (didn't bother creating an option to define it) that looks like this:

[email]
username = ...
password = ...
dest = [e-mail], [e-mail]

[woo]
local_server_url = http://localhost/orangefactor
external_server_url = http://brasstacks.mozilla.com/orangefactor

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 513524 [details] [diff] [review]
Script to mail top-bugs report

Looks great!

Comment 3

[Mark Côté [:mcote]]

Pushed as http://hg.mozilla.org/automation/orangefactor/rev/f70f86a0bef6

Comment 4

[Mark Côté [:mcote]]

Problem sending mail on brasstacks.

Comment 5

[Mark Côté [:mcote]]

Attachment: Add option for regular (non-SSL) SMTP

This is a patch on top of the last patch that allows the sending of emails through regular, non-SSL SMTP.  Adds necessary options and makes 'password' now optional.

Comment 6

[Mark Côté [:mcote]]

Second patch pushed as http://hg.mozilla.org/automation/orangefactor/rev/99b24586dae9

Comment 7

[Mark Côté [:mcote]]

Attachment: More tweaks

A few more tweaks to the emails, as discussed.

Comment 8

[Mark Côté [:mcote]]

Latest patch pushed as http://hg.mozilla.org/automation/orangefactor/rev/629571a1e8aa

Comment 9

[Mark Côté [:mcote]]

Comments from WOO demo in Toronto regarding emails:

- emails should go to dev-tree-management
- emails probably *shouldn't* go to dev-planning except in special circumstances (new orange, large increase/decrease in OF, etc.)
- put OF in subject line
- include last week's OF in body
- put indicator of increase/decrease in OF from last week in subject line (smiley or frowny)

Comment 10

[Jonathan Griffin (:jgriffin)]

I've just subscribed [e-mail] to dev-tree-management.

Comment 11

[Mark Côté [:mcote]]

Attachment: Email improvements

Okay this patch takes care of everything in my last comment.  I also fixed a rounding error in the OF calculation.

I removed the 'test mode' that used cached data from files because it's more complicated now that we grab last week's data too, and I don't feel like making a more complicated caching system right now.  Getting the data has been pretty speedy lately anyway.

I did add a new -t/--test option that prints the email to the screen and doesn't send it.  While I was at it, I made the config file location configurable.

Comment 12

[Jonathan Griffin (:jgriffin)]

Comment on attachment 515936 [details] [diff] [review]
Email improvements

Looks great, I like the smileys.

Comment 13

[Mark Côté [:mcote]]

http://hg.mozilla.org/automation/orangefactor/rev/0466b1c974c8

I think that's it for now.  I'll resolve this, and new email issues can be raised as new bugs.