633030 - "<em:type> doesn't match add-on" error when updating dictionary

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Håvar I. Henriksen [:havarh]]

User-Agent:       Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
Build Identifier: 

Trying to update the Norwegian bokmål and nynorsk dictionary (Norsk bokmål og nynorsk ordliste, addon # 3075, https://addons.mozilla.org/en-US/firefox/addon/norsk-bokm%C3%A5l-og-nynorsk-ordlis/) I get the "<em:type> doesn't match add-on" error when I try to upload a new version of the dictionary (the change I've done is that I've added <em:unpack>true</em:unpack> to the install.rdf file, and edited the version compatibility info).
Btw, this add-on is not listed on the https://addons.mozilla.org/en-US/firefox/language-tools/ page, since this add-on was splitted up in two different dictionaries in 2008. I didn't have any trouble updating the splitted up dictionaries (the Norsk bokmål ordliste, add-on # 6868 and the Norsk nynorsk ordliste, add-on # 6869).
The add-on validates with no errors and no warnings, report: https://addons.mozilla.org/en-US/developers/upload/329605a801564d4e945f150d004fe392

The error seems to be similar to that of comment 16 of bug 626869.

Reproducible: Always

Steps to Reproduce:
1. Upload the new version of the dictionary
2. The add-on validates
3. After clicking the "Add Version" button, the "doesn't match add-on" error message is shown.
Actual Results:  
Add-on is not updated.

Expected Results:  
Add-on should be updated.

The error message is shown as "doesn't match add-on", but after viewing the source code one could see that the error message should be "<em:type> doesn't match add-on", but "<em:type>" isn't shown since the error message isn't htmlentities encoded (maybe I should file a different bug-report about that?).

Comment 1

[Håvar I. Henriksen [:havarh]]

Attachment: The error message I get

This is the error message I get

Comment 2

[Håvar I. Henriksen [:havarh]]

I've uploaded the .xpi file I used here:
http://firefox.no/norsk_bokmal_og_nynorsk_ordliste_2.0.10.2.xpi
(The file was too big to be added as an attachment to this bug, it's 2.1 MiB).

Comment 3

[Jeff Balogh (:jbalogh)]

This add-on has a type of 1 but we should be detecting it as a dict based on the files inside.

Comment 4

[Håvar I. Henriksen [:havarh]]

(In reply to comment #3)
> This add-on has a type of 1 but we should be detecting it as a dict based on
> the files inside.

AMO type is 1, and install manifest[¹] (install.rdf) type is 2. I tried adding <em:type>2</em:type> to the install.rdf file, but that didn't help.

[1]: https://developer.mozilla.org/en/install_manifests

Comment 5

[Matt Basta [:basta]]

This looks like something on the zamboni side of things. Is it known whether this is being thrown by the validator or not?

My local copy is showing a pass with no messages, though it is recognizing the add-on as an extension and not a dictionary (possibly due to the <em:type> not being 2).

Comment 6

[Kumar McMillan [:kumar]]

(In reply to comment #5)
> This looks like something on the zamboni side of things. Is it known whether
> this is being thrown by the validator or not?

This is an error originating from utils.parse_xpi() in zamboni, not the validator, but I cannot reproduce this locally with the addon in comment 2.  Additionally, <em:type> should be escaped in the error message but per the screenshot it's not.

Comment 7

[Jeff Balogh (:jbalogh)]

I changed your add-on to a dictionary so the upload should work now.

Comment 8

[krupa raj[:krupa]]

Håvar, can you check if the upload works now? If yes, please mark the bug as verified. Thanks!

Comment 9

[Håvar I. Henriksen [:havarh]]

Yes, thank you. Now it works. I've managed to upload the dictionary and it already has been reviewed! :-)