633040 - [regression] Text rendering looks scaled

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Stuart Parmenter]

When loading Google News on Android now, our text renders very poorly and looks like it is being bitmap scaled rather than drawn at the correct size.

Comment 1

[Stuart Parmenter]

Attachment: screenshot

Comment 2

[Matt Brubeck (:mbrubeck)]

I'm seeing this in a Linux desktop Fennec build too.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: side by side screenshot

here are screenshots from yesterday and today side by side

Comment 4

[Alon Zakai (:azakai)]

Trying nightlies:

7th - fonts ok
8th and 9th - I can't run them on my device due to bug 632908
10th - fonts are bad

P.S. Comparing builds with dougt, at one point yesterday we were building the exact same changesets, but I was seeing the bug and dougt was not. Only difference we could see in the build settings was my build was a debug one. Very odd.

Comment 5

[Matt Brubeck (:mbrubeck)]

I can see this in desktop in a build from m-c 682d008059c6 (afternoon on 2/9).  I'm starting a bisect to narrow down the regression range.

Comment 6

[Matt Brubeck (:mbrubeck)]

My bisect isn't finished, but I've narrowed it down to this range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ffe65159d&tochange=d0ea866f

so it looks like bug 586683 is the culprit.

Comment 7

[Matt Brubeck (:mbrubeck)]

My bisect says that http://hg.mozilla.org/mozilla-central/rev/b0512b9a8c11 is the first bad revision.  I suspect this is incorrect, since it looks like that changeset should not alter any behavior; perhaps I mis-marked one of the revisions that I tested.  The regression range was definitely somewhere within bug 586683, however.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix?

Does this fix it?

Comment 9

[Matt Brubeck (:mbrubeck)]

Yes, attachment 511513 [details] [diff] [review] fixes the bug for me.

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Writing a reftest for this is a bit tricky.  It would be very easy to extend bug 624636 to allow setting content resolution, but it would take a fair amount of new code to allow setting a view transform in the browser, on the shadow layers.  There's probably a cleverer way to check this with only the content resolution and maybe CSS transforms.  Homework problem!

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9e8f138a8b9e