PSM not in packages-win file

VERIFIED FIXED

Status

()

Core
Security: PSM
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: Javier Delgadillo, Assigned: Sean Su)

Tracking

1.0 Branch
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

18 years ago
PSM now builds as part of mozilla, but it is not included in the packages for
windows.

Patch to come shortly.
(Reporter)

Comment 1

18 years ago
Created attachment 20982 [details] [diff] [review]
Patch to include psm files in the mozilla win32 package

Comment 2

18 years ago
Please create an additional package for PSM, and make it deselectable in the
installer.
(Reporter)

Comment 3

18 years ago
And how do you do that?

Comment 4

18 years ago
I'll look into it. I'll attach some preliminary fixes. I have no Win32 build
envioronment, so you'll have to go on from there and test them and fix possible
problems. Shouldn't be hard.

Comment 5

18 years ago
Created attachment 21011 [details] [diff] [review]
Possible Fix, diff, Version 1

Comment 6

18 years ago
Created attachment 21012 [details]
Possible Fix, Version 1, psm.jst

Comment 7

18 years ago
I never did this before, and there is no documentation (to my knowledege), so
please excuse, if it doesn't work. But it seems like this should do the trick.
Version: 1.01 → 1.4
(Reporter)

Comment 8

18 years ago
*** Bug 63401 has been marked as a duplicate of this bug. ***
(Reporter)

Comment 9

18 years ago
Somebody who knows how to test this will have to take over.  I don't know if I
even have the correct environment for testing packaging.

Comment 10

18 years ago
ccing ssu since he's the win32 installer guru.  Won't this require a change to
makeall.pl or some other part of the build system?
(Assignee)

Comment 11

18 years ago
Javier, go ahead and check in your patch.  It can be done right now without
harming the build process.  I will need that checked in before (or at the same
time) my change to the installer goes in.

I will work on making sure that the windows installer has offers psm.  Right
now, I need some input.  The mozilla installer currenly has three Setup Types:
  Browser Only
  Complete
  Custom

I know we want psm to be visible in the Custom dialogs (so the user can opt out
of it), but what about the other two Setup Types?  Do we want to install psm
with them as well?  I need answers to these questions before I can proceed.
(Assignee)

Comment 12

18 years ago
And what should the description be in the installer for psm?  For the NS build,
we currently have:
  Netscape Personal Security Manager (this shows up next to the checkbox)
  Security for the Netscape browser (this shows up in a description window below
the list of components when the psm component is highlited)

Sounds cheesy to me.  Anyone got better ones?
Also, where should psm get installed to?  the NS build installs it to the
following default place (under windows of course):

  [Common Files]\Netscape\Security

Does the mozilla version of psm work with Netscape 6?  if so do we want a common
place for psm so both can use it?
(Assignee)

Comment 13

18 years ago
Javier,  I just looked at your patch more carefully.  Don't check that one in.
The psm files need to be in their own [psm] section in the packages-win file.
If they are not, then they will be packaged up as part of another component.

Looks like Ben Bucksch has the right patches, though it would still be a good
idea to answer the questions I've posted.
(Reporter)

Comment 14

18 years ago
Whoops, I didn't get your next message in time.

Backing out my check-in.
(Reporter)

Comment 15

18 years ago
Backed out my previous check-in.

The version of PSM built in mozilla now needs to live in the same directory as
mozilla.exe because we now share the components with the browser.  We'd have to
bundle together all the components we need if we want to put in a different
place.  For now, it needs to stay in the same directory.


You need to place psm.exe and nssckbi.dll in the same directory as mozilla.exe
and place the psmdata directory there as well.

Seems that having a box say something like "Use Personal Security Manager (PSM)
for crypto operations" would work.
(Assignee)

Comment 16

18 years ago
I have a slightly revised patch from Ben Bucksch's patch (I hope you don't mind
that I updated your patch).  I will attach the patch later.  However, I have
found a possible build conflict with the ns builds if psm is enabled into the
mozilla builds.

What I need to know is if mozilla's psm works with the ns builds.  Javi, if the
answer is yes, then a fix is simple.  If the answer is no, I will need to
briefly talk to leaf to resolve the conflict.
(Assignee)

Comment 17

18 years ago
reassigning this to myself.  I have all the answer I need.  I'm testing a new
patch.  will post it soon.
Assignee: javi → ssu
(Assignee)

Comment 18

18 years ago
Created attachment 21175 [details] [diff] [review]
patch v2 for mozilla tree
(Assignee)

Comment 19

18 years ago
Created attachment 21176 [details] [diff] [review]
patch v2 for ns tree
(Assignee)

Comment 20

18 years ago
The patch v2 that I've attached are slight modifications from Ben Bucksch's
initial patches.

looking for reviewers now.
Status: NEW → ASSIGNED

Comment 21

18 years ago
r=leaf for v2 patches
(Assignee)

Comment 22

18 years ago
got r=sgehani too.

Comment 23

18 years ago
sr=bienvenu
(Assignee)

Comment 24

18 years ago
okay, patches finally checked in.  psm should be installed in the next
mozilla/ns builds.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 25

18 years ago
works okay for build 2000122220. Thanks.

Comment 26

18 years ago
Verified on 12/28 WinNT nightly build.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: PSM → Security: PSM
Product: PSM → Core

Updated

10 years ago
Version: psm1.4 → 1.0 Branch
You need to log in before you can comment on or make changes to this bug.