Rewrite afterAllTabItemsUpdated in head.js using a tabItem observer

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
P4
normal
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: Sean Dunn, Assigned: ttaubert)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Right now in head.js's afterAllTabItemsUpdated we call update on each of them, essentially bypassing the TabPriorityQueue. Adding the _updateTestFunc hook to  check that they're all updated and then calling update() on them is much more graceful. Rewrite afterAllTabItemsUpdated in terms of this kind of  tabPriorityQueue-obeying logic, and making sure all the tests still pass.

Updated

7 years ago
Priority: -- → P4
No longer blocks: 585689
Blocks: 603789

Comment 1

7 years ago
bugspam
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Summary: Rewrite afterAllTabItemsUpdated in head.js using TabItem._updateTestFunc. → Rewrite afterAllTabItemsUpdated in head.js using a tabItem observer
Created attachment 524910 [details] [diff] [review]
patch v1
Attachment #524910 - Flags: feedback?(raymond)
Comment on attachment 524910 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=f908b24a2c25
Comment on attachment 524910 [details] [diff] [review]
patch v1

Looks good to me.
Attachment #524910 - Flags: feedback?(raymond) → feedback+
Attachment #524910 - Flags: review?(ian)
Comment on attachment 524910 [details] [diff] [review]
patch v1

Looks fine, but can you explain why those two tests had to be changed?
Attachment #524910 - Flags: review?(ian) → review+
Created attachment 528001 [details] [diff] [review]
patch v2

(In reply to comment #5)
> Looks fine, but can you explain why those two tests had to be changed?

browser_tabview_expander.js:

The problem is that newly created tabs with the url "about:blank#something" have a readyState == "uninitialized". So TabItem.isComplete() will never return true and the update will never occur. That is why I changed the url to "about:home". Alternatively we could also remove the hash.

browser_tabview_bug594958.js:

In bug 625561 (http://hg.mozilla.org/mozilla-central/rev/20ffcaad9700) these values got changed and I can't really remember why. So what I did was to re-think the whole test and to re-check the given values so that they're now correct and the thumbnails are rendered as expected. I think this will also help us the continue with bug 641188.
Attachment #524910 - Attachment is obsolete: true
Attachment #528001 - Flags: review?(ian)
(In reply to comment #6)
> I think this will also help us the continue with bug 641188.

It does. I'll post in bug 641188.
Comment on attachment 528001 [details] [diff] [review]
patch v2

Review of attachment 528001 [details] [diff] [review]:

Cool, thanks
Attachment #528001 - Flags: review?(ian) → review+
No longer blocks: 603789
Blocks: 653099
bugspam
No longer blocks: 653099
bugspam
Blocks: 660175
bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)
No longer blocks: 660175
Is there any concerns why this patch is not checked-in?
Yeah, alas, this patch does not pass try. I tried to find the error source but wasn't very successful so far and didn't have much time to try it further (because that's such a minor issue).
Fixed by bug 659594.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Depends on: 659594
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.