Closed Bug 633121 Opened 9 years ago Closed 9 years ago

Implement BrowserReloadOrDuplicate for FF parity

Categories

(SeaMonkey :: Sync UI, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Some tests need this, as well as extensions can use it. The patch above is a simple stub, as we have everything implemented in BrowserReload.
Attachment #511324 - Flags: review?(neil)
NB: Dao changed their duplicateTabIn() to match our OpenSessionHistoryIn()
Unfortunately earlier we implemented a stub duplicateTabIn() to match their old implementation.

Current Firefox:
function duplicateTabIn(aTab, where, delta) {
Current SeaMonkey:
function duplicateTabIn(aTab, aWhere, aHistoryIndex)

So while you are at it just change our implementation of duplicateTabIn() to just directly pass aDelta directly to OpenSessionHistoryIn() (and change the comment as well)
Comment on attachment 511324 [details] [diff] [review]
patch

I don't see the point of this right now. We can rethink this if we get complaints from extension authors.
Attachment #511324 - Flags: review?(neil)
I was needing this for ongoing bug's test, but I'll chage them to use BrowserReload ...
Component: Tabbed Browser → Sync UI
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
(In reply to comment #1)
> NB: Dao changed their duplicateTabIn() to match our OpenSessionHistoryIn()
> Unfortunately earlier we implemented a stub duplicateTabIn() to match their old
> implementation.
> 
> Current Firefox:
> function duplicateTabIn(aTab, where, delta) {
> Current SeaMonkey:
> function duplicateTabIn(aTab, aWhere, aHistoryIndex)
> 
> So while you are at it just change our implementation of duplicateTabIn() to
> just directly pass aDelta directly to OpenSessionHistoryIn() (and change the
> comment as well)

Actually you can now call OpenSessionHistoryIn directly. The only difference is the order of the arguments.
> Actually you can now call OpenSessionHistoryIn directly. The only difference is
> the order of the arguments.

Earlier when I implemented the clone tab stuff you agreed to this:
/* Firefox compatibility shim *
 * duplicateTabIn duplicates tab in a place specified by the parameter |where|.
You need to log in before you can comment on or make changes to this bug.