633121 - Implement BrowserReloadOrDuplicate for FF parity

Status: RESOLVED WONTFIX

(SeaMonkey :: Sync UI, defect)

Description

[Misak Khachatryan]

Attachment: patch

Some tests need this, as well as extensions can use it. The patch above is a simple stub, as we have everything implemented in BrowserReload.

Comment 1

[Philip Chee]

NB: Dao changed their duplicateTabIn() to match our OpenSessionHistoryIn()
Unfortunately earlier we implemented a stub duplicateTabIn() to match their old implementation.

Current Firefox:
function duplicateTabIn(aTab, where, delta) {
Current SeaMonkey:
function duplicateTabIn(aTab, aWhere, aHistoryIndex)

So while you are at it just change our implementation of duplicateTabIn() to just directly pass aDelta directly to OpenSessionHistoryIn() (and change the comment as well)

Comment 2

[[e-mail]]

Comment on attachment 511324 [details] [diff] [review]
patch

I don't see the point of this right now. We can rethink this if we get complaints from extension authors.

Comment 3

[Misak Khachatryan]

I was needing this for ongoing bug's test, but I'll chage them to use BrowserReload ...

Comment 4

[[e-mail]]

(In reply to comment #1)
> NB: Dao changed their duplicateTabIn() to match our OpenSessionHistoryIn()
> Unfortunately earlier we implemented a stub duplicateTabIn() to match their old
> implementation.
> 
> Current Firefox:
> function duplicateTabIn(aTab, where, delta) {
> Current SeaMonkey:
> function duplicateTabIn(aTab, aWhere, aHistoryIndex)
> 
> So while you are at it just change our implementation of duplicateTabIn() to
> just directly pass aDelta directly to OpenSessionHistoryIn() (and change the
> comment as well)

Actually you can now call OpenSessionHistoryIn directly. The only difference is the order of the arguments.

Comment 5

[Philip Chee]

> Actually you can now call OpenSessionHistoryIn directly. The only difference is
> the order of the arguments.

Earlier when I implemented the clone tab stuff you agreed to this:
/* Firefox compatibility shim *
 * duplicateTabIn duplicates tab in a place specified by the parameter |where|.