633227 - Add uninteresting IPC functions to skiplist

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Josh Matthews [:jdm]]

Specifically, I'm thinking of mozilla::ipc::RPCChannel::CxxStackFrame::CxxStackFrame and mozilla::ipc::RPCChannel::Send.  All they do is group every ipc actor error under the same signature, which is annoying.

Comment 1

[Benjamin Smedberg]

The skiplist, or the appendlist? And do you have a specific set of frames to add to the list?

Comment 2

[Josh Matthews [:jdm]]

Judging by the names, I presume skiplist means that the function names are elided completely, whereas appendlist is where you have mozilla::ipc::RPCChannel::CxxStackFrame::CxxStackFrame | mozilla::ipc::RPCChannel::Send | mozilla::dom::PContentPermissionRequestParent::Send__delete__ ?  I suppose the appendlist would be better in this case.

Comment 3

[Benjamin Smedberg]

yes, precisely. Can you come up with a comprehensive list of frames you want on the appendlist?

Comment 4

[Josh Matthews [:jdm]]

mozilla::ipc::RPCChannel::EnteredCxxStack
mozilla::ipc::RPCChannel::CxxStackFrame::CxxStackFrame
mozilla::ipc::RPCChannel::Send
mozilla::ipc::RPCChannel::Call

I think these are all the ones that I'm concerned about.  Chris, any input here?

Comment 5

[Josh Matthews [:jdm]]

Ok, I'm happy with this list of functions. Can we get them added to the appendlist, please?

Comment 6

[Laura Thomson :laura]

For future requests it's worth reading through 
https://wiki.mozilla.org/Breakpad/Skip_List_How_To

From the description I'm assuming you want these frames added to the prefixSignatureRegEx.  I'll proceed with that.

Comment 7

[Laura Thomson :laura]

Pull request: https://github.com/mozilla/socorro/pull/6

Comment 8

[Laura Thomson :laura]

lonnen: r?

Comment 9

[Lonnen :lonnen]

r+

Comment 10

[Laura Thomson :laura]

Landed in
https://github.com/mozilla/socorro/commit/20b185066336561bfce8b6a74b50b5da5bf2ccd2