Last Comment Bug 633240 - nsIMIMEService.getTypeFromFile(null) crashes [@ nsExternalHelperAppService::GetTypeFromFile(nsIFile*, nsACString_internal&) ]
: nsIMIMEService.getTypeFromFile(null) crashes [@ nsExternalHelperAppService::G...
Status: RESOLVED FIXED
: crash
Product: Core Graveyard
Classification: Graveyard
Component: File Handling (show other bugs)
: Trunk
: All All
: -- critical (vote)
: mozilla6
Assigned To: timeless
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-10 09:46 PST by Dave Garrett
Modified: 2016-06-22 12:16 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---
?
?
?

Attachments
patch (703 bytes, patch)
2011-02-27 18:51 PST, timeless 		cbiesinger: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Dave Garrett 2011-02-10 09:46:33 PST 
Same problem as bug 633232 with a different function.

Easy test: execute this in the Error Console for an crash:
Components.classes["@mozilla.org/mime;1"].getService(Components.interfaces.nsIMIMEService).getTypeFromFile(null);

3.6.13 on Windows:  bp-7b7bd39c-4a4d-4964-85e7-3914f2110210
3.6.13 on Linux:    bp-777ec39c-3ac5-414f-b4df-4f3832110210
4.0b12pre on Linux: bp-c35974d7-650e-4f32-996f-f1d592110210

http://hg.mozilla.org/releases/mozilla-1.9.2/annotate/0c159bd1d600/uriloader/exthandler/nsExternalHelperAppService.cpp#l2721

Looks like it just needs a null check for aFile up top.
Comment 1 Dave Garrett 2011-02-24 12:34:09 PST 
Not a candidate for blocking, as far as I can tell. It's been this way since at least Firefox 3.0 and I don't see a way to get at this from the web, though if anyone else does please say so. Requesting wanted+ for all affected branches.
Comment 2 timeless 2011-02-27 18:51:48 PST 
Created attachment 515546 [details] [diff] [review]
patch
Comment 3 Dave Garrett 2011-04-25 11:16:49 PDT 
These two crash bugs (bug 633232 & bug 633240) have reviewed one-line patches. Any reason they can't land now? They should at least be able to land on Trunk at this point, I would think. Could they also make Firefox 4.0.1 too?
Comment 4 Dão Gottwald [:dao] 2011-04-27 03:15:27 PDT 
http://hg.mozilla.org/mozilla-central/rev/225fff91e7ad
Note You need to log in before you can comment on or make changes to this bug.