Closed Bug 633240 Opened 11 years ago Closed 11 years ago

nsIMIMEService.getTypeFromFile(null) crashes [@ nsExternalHelperAppService::GetTypeFromFile(nsIFile*, nsACString_internal&) ]

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(status2.0 ?, status1.9.2 ?, status1.9.1 ?)

Status:
RESOLVED FIXED
Milestone:
mozilla6
Tracking Flags:
Tracking Status
status2.0 --- ?
status1.9.2 --- ?
status1.9.1 --- ?

People

(Reporter: davemgarrett, Assigned: timeless)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

patch
703 bytes, patch
Biesinger
: review+
Details | Diff | Splinter Review 
Same problem as bug 633232 with a different function.

Easy test: execute this in the Error Console for an crash:
Components.classes["@mozilla.org/mime;1"].getService(Components.interfaces.nsIMIMEService).getTypeFromFile(null);

3.6.13 on Windows:  bp-7b7bd39c-4a4d-4964-85e7-3914f2110210
3.6.13 on Linux:    bp-777ec39c-3ac5-414f-b4df-4f3832110210
4.0b12pre on Linux: bp-c35974d7-650e-4f32-996f-f1d592110210

http://hg.mozilla.org/releases/mozilla-1.9.2/annotate/0c159bd1d600/uriloader/exthandler/nsExternalHelperAppService.cpp#l2721

Looks like it just needs a null check for aFile up top.
Component: General → File Handling
QA Contact: general → file-handling
Not a candidate for blocking, as far as I can tell. It's been this way since at least Firefox 3.0 and I don't see a way to get at this from the web, though if anyone else does please say so. Requesting wanted+ for all affected branches.
status1.9.1: --- → ?
status1.9.2: --- → ?
status2.0: --- → ?
Attached patch patch — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #515546 - Flags: review?(cbiesinger)
Attachment #515546 - Flags: review?(cbiesinger) → review+
These two crash bugs (bug 633232 & bug 633240) have reviewed one-line patches. Any reason they can't land now? They should at least be able to land on Trunk at this point, I would think. Could they also make Firefox 4.0.1 too?
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/225fff91e7ad
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Crash Signature: [@ nsExternalHelperAppService::GetTypeFromFile(nsIFile*, nsACString_internal&) ]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.