Convert editor queue pages to model-like SQL instead of views

RESOLVED FIXED in 5.12.10

Status

defect
P1
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: kumar, Assigned: kumar)

Tracking

unspecified
5.12.10

Details

(Whiteboard: [ReviewTeam])

The editor pages were built quickly using views.  However, this doesn't scale to support advanced searching (bug 622171).  Instead, the queue pages need to support raw SQL with limited compatibility with Django's model and query set.

Here are some reasons:

- Views are great for straight queue pages but are too slow for the queries needed to support advanced search
- Alternatively, creating many more views for each type of advanced search item would be cumbersome to maintain
- Standard Django models cannot be used because they create too many joins and subqueries (page would be too slow)
- Django's support of raw SQL also can't be used because it still ultimately ends in creating a single model instance
- Non-Django raw SQL could be used but it would introduce a lot more effort since we'd have to re-write the data grid sorting and pagination
Assignee: nobody → kumar.mcmillan
Priority: -- → P1
Target Milestone: --- → 5.12.10
It's also worth noting that I could not find an existing raw SQL implementation like this, not one that was compatible with the data grid.
Jorge, are all the advanced search features needed?

Kumar, would it be easier to use sphinx for this?
(In reply to comment #2)
> Jorge, are all the advanced search features needed?

I know there are a few editors who use the advanced features. So, yes, I think they should continue to work in the same way.
Whiteboard: [required amo-editors]
Fixed in https://github.com/jbalogh/zamboni/commit/05b771e48172753bf01d47f36a06ad1bf55a8ed1
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.