crash [@ nsCOMPtr_base::assign_assuming_AddRef | nsCOMPtr_base::assign_with_AddRef | nsHTMLMediaElement::Error]

VERIFIED FIXED

Status

()

Core
Audio/Video
--
critical
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: jdm, Assigned: kinetik)

Tracking

({crash})

Trunk
All
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
This bug was filed from the Socorro interface and is 
report bp-71773692-0a4a-4e89-90a3-d0f472110209 .
============================================================= 

0 	libxul.so 	nsCOMPtr_base::assign_assuming_AddRef 	nsCOMPtr.h:474
1 	libxul.so 	nsCOMPtr_base::assign_with_AddRef 	nsCOMPtr.cpp:90
2 	libxul.so 	nsHTMLMediaElement::Error 	content/html/content/src/nsHTMLMediaElement.cpp:2005
3 	libxul.so 	nsHTMLMediaElement::LoadAborted 	content/html/content/src/nsHTMLMediaElement.cpp:1996
4 	libxul.so 	nsWaveDecoder::NotifyDownloadEnded 	content/media/wave/nsWaveDecoder.cpp:1552
5 	libxul.so 	DataEnded::Run 	content/media/nsMediaStream.cpp:723

We're looking at a null mElement in nsWaveDecoder, I believe.  Coincidentally, mElement is null-checked every single single place it's used in the decoder except for NotifyDownloadEnded.
(Reporter)

Updated

7 years ago
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general → video.audio
(Assignee)

Comment 1

7 years ago
Created attachment 513360 [details] [diff] [review]
patch v0

Trivial crash fix.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #513360 - Flags: review?(chris)
Attachment #513360 - Flags: review?(chris) → review+
(Assignee)

Updated

7 years ago
Attachment #513360 - Flags: approval2.0?
Attachment #513360 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/07b8187bdc68
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsCOMPtr_base::assign_assuming_AddRef | nsCOMPtr_base::assign_with_AddRef | nsHTMLMediaElement::Error]
You need to log in before you can comment on or make changes to this bug.