633412 - Change Win2003 -> WinXP

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

Orange Factor is using a label of Win2003 for WINNT 5.1 builds, but in reality this is Windows XP; I don't believe we're running tests on Win2003 any longer.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

actually from woo.utils.js:
platforms = {'Linux':'Fedora 12',
             'Linux 64':'Fedora 12x64',
             'OS X':'MacOSX Leopard 10.5.8',
             'OS X64':'MacOSX Snow Leopard 10.6.2',
//             'WinXP':'WINNT 5.1',
             'Win2003':'WINNT 5.2',
             'Win7':'WINNT 6.1'};

currently 5.1 is commented out.  iirc, this was the case when I first started mining bugzilla comments in August 2010.  Just a quick look at tbpl and we have WinXP as a platform.  Maybe we should reverse these and only show the 5.1 platform.  

I believe if we have an unknown platform we silently ignore it.

Comment 2

[Phil Ringnalda (:philor)]

We build on 2K3, so we run make check on it, so we do have orange on it still (though I don't think I've ever looked at whether woo knows about the few bits of orange make check produces).

XP talos has been around for a while, but opt XP non-talos tests are just a month or so old, and debug XP tests are coming sometime in the future.

Comment 3

[Mark Côté [:mcote]]

Attachment: Changed platform string mapping

I think this solves this bug.  I switched the platforms structure (and the other orange-detail structures) from mapping from heat-map abbreviation -> detail string to detail string -> displayable name.  Everything other than platform just displays the string as found in the JSON (e.g. 'mochitests-2/5', 'mozilla-central', 'opt', etc.).  The platform mapping is now

platforms = {'Fedora 12':'Linux',
             'Fedora 12x64':'Linux 64',
             'MacOSX Leopard 10.5.8':'OS X',
             'MacOSX Snow Leopard 10.6.2':'OS X 64',
             'WINNT 5.1':'Windows XP',
             'WINNT 5.2':'Windows 2003',
             'WINNT 6.1':'Windows 7'};

This is used in the dropdowns on Orange Factor, on the graph by platform on Bug Count, and in the Bug Details table.

If this isn't right, or if we want the full platform name for some, let me know.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Changed platform string mapping (unbitrot version)

fixed the small bit of bitrot in this.

Comment 5

[Mark Côté [:mcote]]

Thanks for the updated patch.  Pushed as http://hg.mozilla.org/automation/orangefactor/rev/5691922a5632