Closed
Bug 633457
Opened 12 years ago
Closed 12 years ago
Firefox hangs at startup
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
(Keywords: hang, Whiteboard: [hardblocker][has patch])
Attachments
(2 files)
5.06 KB,
text/plain
|
Details | |
949 bytes,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
It's not 100% reproducible. It happens if $HOME/.mozilla doesn't exist and memory is low (maybe). I see this problem a lot with LiveCD on VirtualBox or VMWare. Stack attached.
In lwp# 1, it is shutting down sCollectorThread. sCollectorRunner should have already been shutdown. Why do we still have lwp# 3 ?
I believe the reason is lwp# 1 did Shutdown() before lwp # 3 setting mRunning to TRUE. i.e. lwp# 1 returns from Shutdown() at http://hg.mozilla.org/mozilla-central/file/1ed3464aaa92/xpcom/base/nsCycleCollector.cpp#l3372 then lwp#3 starts running at http://hg.mozilla.org/mozilla-central/file/1ed3464aaa92/xpcom/base/nsCycleCollector.cpp#l3302
blocking2.0: --- → ?
Comment 6•12 years ago
|
||
Yeah, this looks like a recent regression from the cycle-collector threading stuff.
blocking2.0: ? → final+
Whiteboard: [hardblocker]
Hm, why are we shutting down so early? Patch looks good btw.
Updated•12 years ago
|
Whiteboard: [hardblocker] → [hardblocker][has patch]
(In reply to comment #7) > Hm, why are we shutting down so early? Because we're restarting.
Does this bug only affect OpenSolaris?
Assignee | ||
Comment 10•12 years ago
|
||
In theory, it affects all platforms. It is a race condition.
(In reply to comment #8) > (In reply to comment #7) > > Hm, why are we shutting down so early? > > Because we're restarting. Huh, I thought we got rid of all that restart-on-startup stuff...
Ginn, I'd be happy to review this, but can you attach a patch with -P and a little more context? 'diff -U8 -P' is what i usually use.
Updated•12 years ago
|
OS: OpenSolaris → Linux
Updated•12 years ago
|
Attachment #511913 -
Flags: review?(peterv)
Attachment #511913 -
Flags: review?(dbaron)
Attachment #511913 -
Flags: review?(bent.mozilla)
Comment on attachment 511913 [details] [diff] [review] patch This looks fine to me! Thanks.
Attachment #511913 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 14•12 years ago
|
||
(In reply to comment #12) > Ginn, I'd be happy to review this, but can you attach a patch with -P and a > little more context? 'diff -U8 -P' is what i usually use. Sorry, I made the patch in VM so I missed my .hgrc.
OS: Linux → Windows CE
Comment on attachment 511913 [details] [diff] [review] patch I think dbaron wanted bent||peterv, rather than bent&&peterv, so clearing other review req. I'll push this soon.
Attachment #511913 -
Flags: review?(peterv)
http://hg.mozilla.org/mozilla-central/rev/afba7603a946
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Windows CE → All
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•