Closed Bug 633465 Opened 9 years ago Closed 9 years ago

Turn off bug 591836 workaround on Win64

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

Windows build still use shared js engine (mozjs.dll) due to bug 591836 comment #24 and http://hg.mozilla.org/mozilla-central/rev/0ff917ab21e4.

But this is for Visual Studio 2005 x86 PGO issue, so Win64 build can use static js because build environment is Visual Studio 2008 SP1.

I try testing PGO on VS2008 with static js, there is no crash.
Attached patch fixSplinter Review
Assignee: general → m_kato
Attachment #513043 - Flags: review?(khuey)
Comment on attachment 513043 [details] [diff] [review]
fix

Win64 only
Attachment #513043 - Flags: approval2.0?
Attachment #513043 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/554fa6c29f07
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Depends on: 830594
You need to log in before you can comment on or make changes to this bug.