633497 - Wrong behavior when trying to rechange language from Preferences

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

Attachment: actual result

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre Fennec /4.0b5pre 

Devices: Motorola Droid 2 (Android 2.2), HTC Desire (Android 2.2), Samsung S Galaxy Captivate (Android 2.1 update 1)

Steps to reproduce:
1. Drag the cursor to the left to the open the controls sidebar
2. Go to Options | Preferences
3. Click on the button on the same row as "Language"
4. Assuming that "Auto-Detect" is selected, select other language (e.g.: Español)
5. Restart the browser.
6. This time, tap on the system menu button.
7. From the list of options select Preferences. (Preferencias)
8. Click on the button on the same row as "Language"
   
Actual results:
Only the option "Auto-detect" (Autodetectar) is present in the list. Please see the attached photo and also the attached log.

Expected results:
The full list of languages should be present.

Note: If you go to the Preferences menu, by panning the screen to the left and not by clicking the system menu button this issue does not reproduce.

Comment 1

[Anna (Waverley)]

Attachment: Log

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Using the Android menu does not force the "select" event to be fired?

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to comment #2)
> Using the Android menu does not force the "select" event to be fired?

Yup, that's right.  Bug 627851 exposed this problem, since it stopped us from listening to the "wrong" select events.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Push the "select" event down into switchPane, so it will be called whether you press the gear button or use the app menu.

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/62ec610c80fc

Comment 6

[Anna (Waverley)]

Verified Fixed: 
Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre Fennec /4.0b5pre

Device: Motorola Droid 2 (Android 2.2)