633511 - WebGL broken with D2D [@ gfxASurface::GetContentType()]

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[José Jeria]

This bug was filed from the Socorro interface and is 
report bp-90743bfe-6d57-42af-b14a-c7adf2110211 .
============================================================= 

Steps to reproduce
1. visit http://web.chemdoodle.com/tutorial/3d-structure-canvases/transformer3d-canvas

Graphic card info:
        Adapter Description
        ATI Mobility Radeon HD 3400 Series

        Vendor ID
        1002

        Device ID
        95c4

        Adapter RAM
        256

        Adapter Drivers
        atiu9p64.dll atiuxp64 atiu9pag atiuxpag atiumdva atiumd6a atitmm64

        Driver Version
        8.752.4.0

        Driver Date
        10-22-2010

        Direct2D Enabled
        true

        DirectWrite Enabled
        true (6.1.7600.20781, font cache n/a)

        WebGL Renderer
        Google Inc. -- ANGLE -- OpenGL ES 2.0 (ANGLE 0.0.0.541)

        GPU Accelerated Windows
        1/1 Direct3D 10

Comment 1

[Scoobidiver (away)]

4.0b12pre/20110210: works
4.0b12pre/20110211: crashes

The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=199cb6282554&tochange=1ed3464aaa92

Comment 2

[Boris Zbarsky [:bzbarsky]]

Looks like a null-deref regression from bug 628173 ?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We regressed this on a mostly cosmetic change. we should be able to back it out if need be.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Detect content type in the right place

I messed up and did content type in the wrong place (where it got a shared WebGL surface rather than a cairo surface). This fixes that.

This blocks beta as it essentially makes WebGL not work on D3D10 at all.

Comment 5

[Bas Schouten (:bas.schouten)]

Requesting blocking beta for proper tracking.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

meta question -- how did this not turn webgl tests red?  do we not have any machines that run both d3d10 + d2d + webgl tests?  (which will, I suspect, be a pretty common combination!)

Comment 7

[Bas Schouten (:bas.schouten)]

(In reply to comment #6)
> meta question -- how did this not turn webgl tests red?  do we not have any
> machines that run both d3d10 + d2d + webgl tests?  (which will, I suspect, be a
> pretty common combination!)

This occured only when using ANGLE(D3D9)/D3D10 interop. This is disabled on the test machines currently. Jeff created a bug to change this.

Comment 8

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/d6f1b1a06eb8

Comment 9

[José Jeria]

Verified fixed.