633613 - Add and localized Spark game graphic to Start page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Caitlin Looney]

Starting Firefox 4 final launch day for three weeks, we'd like to place the Spark game banner at the bottom of the Start page. (Files coming soon). This banner, when tapped, will redirect to the Spark game Web app. (URL coming soon). 

This banner needs to be localized as well.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We'll need to get the string in for beta 5. As far as I know right now, the string will be:

"Play Firefox Spark"

And will appear in a footer on the about:home page. An image will also be in the footer.

To keep things simple and not need network pings, I suggest we just add a "promo.timeout" pref and set it with the date the promo will stop.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patchs adds everything for the feature, except:
* final image of spark
* URL to navigate on tap

The patch uses a preference ("app.promo.spark.endDate") to control hiding/showing the promo on the home page. I have it set for 2011-01-01 for now so it does not become visible in beta 5 or the nightlies. You can change the date to make it visible.

We should land this patch for beta 5 so the strings are in. If the final artwork and/or URL become available, we could land those too, but followup patches are fine for those.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: screenshot

This is how it looks

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 511973 [details] [diff] [review]
patch

Code looks good but I hope adblock will arrived soon on mobile...

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/ab003bb65c93

we still need final images and a URL, but this doesn't need to block beta 5 anymore. Blocking 2.0 now

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Easier to track as a new bug: bug 633769

Comment 7

[Aaron Train [:aaronmt]]

Verified fixed with what is currently available on 
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre) Gecko/20110214Firefox/4.0b12pre Fennec/4.0b5pre

Tested English/French/Russian languages and see a localized banner