SpiderMonkey automated testing doesn't work on Windows

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Paul Biggar, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
The new SpiderMonkey shell builds don't work on Windows because windows is weird. I worked this out before sometime, but it's still a pain (https://developer.mozilla.org/en/SpiderMonkey_Build_Documentation#NSPR_on_Windows).

Basically, instead of the standard unix way of:

   --with-nspr-libs=`nspr-config --libs`

we need to specify the libs directly in the configure line:

   --with-nspr-libs="$OBJDIR/dist/lib/plds4.lib $OBJDIR/dist/lib/plc4.lib $OBJDIR/dist/lib/nspr4.lib"

Then we need the PATH:

    PATH="$PATH:$OBJDIR/dist/lib" ./js --help
(Assignee)

Updated

7 years ago
Assignee: nobody → catlee
(Assignee)

Comment 1

7 years ago
Created attachment 513122 [details] [diff] [review]
Fix windows

This looks like it fixes things on my staging systems.
Attachment #513122 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #513122 - Flags: review? → review?(pbiggar)
(Reporter)

Comment 2

7 years ago
Comment on attachment 513122 [details] [diff] [review]
Fix windows

Looks good to me.
Attachment #513122 - Flags: review?(pbiggar) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 513122 [details] [diff] [review]
Fix windows

http://hg.mozilla.org/build/tools/rev/f96bcb9e8554
Attachment #513122 - Flags: checked-in+
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.