Closed
Bug 633744
Opened 13 years ago
Closed 10 years ago
503 Service Unavailable searching for collection with leading "@$%" characters
Categories
(addons.mozilla.org Graveyard :: Search, defect)
addons.mozilla.org Graveyard
Search
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: stephend, Unassigned)
References
()
Details
(Whiteboard: [fromAutomation])
This has been haunting our automated tests for a while. We're able to create collections with names like @$%2345678901234567890123456789 [1], yet searching for them yields: [09:14:32.928] GET https://addons.allizom.org/en-US/firefox/search/?q=%40%24%252345678901234567890123456789&cat=collections&x=0&y=0 [HTTP/1.1 503 SERVICE UNAVAILABLE 384ms] [1] https://addons.allizom.org/en-US/firefox/collections/stephend/23456789012345678901234567890/ is the actual URL, even though the printed name is preceded by "@$%", which we strip away in the slug -- the thing is, we don't index it by its actual slug name, since https://addons.allizom.org/en-US/firefox/search/?q=23456789012345678901234567890&cat=collections&x=0&y=0 doesn't find anything. (I do realize this is a tad pathological, but if we accept and create a collection, we should be able to search for it by its printed name.)
Comment 2•13 years ago
|
||
To expand, you get search unavailable for any string that starts with @$ and has at least one char after it - "@$a", "@$%", "@$ab8y635ia3" all break it. However, just @$ returns a regular search (no breakage). Also no breakage for if you try to isolate the two chars (so @ is ok, @a is ok, $ is ok, $a is ok).
Reporter | ||
Comment 3•13 years ago
|
||
Dave/Wil: any chance we can get this fixed within the next couple of milestones? We have enough disabled tests in our suite as it is :-(
Comment 4•13 years ago
|
||
(In reply to comment #3) > Dave/Wil: any chance we can get this fixed within the next couple of > milestones? We have enough disabled tests in our suite as it is :-( It's not a priority. :-/
Comment 5•13 years ago
|
||
I could lift the 503, but I don't think I could solve this: "I do realize this is a tad pathological, but if we accept and create a collection, we should be able to search for it by its printed name." I'm willing to give this a look, but searching for special characters has always been difficult. As far as timeline goes, I'm devoting much of this quarter to Elastic Search, which I think will replace Sphinx on AMO at some point.
Reporter | ||
Comment 6•13 years ago
|
||
I've updated https://addons.allizom.org/en-US/firefox/collections/stephend/23456789012345678901234567890/, with a note to restore the leading special chars once this bug is fixed, or obviated, since this is (understandably) not a high priority. Thanks :-)
Reporter | ||
Updated•13 years ago
|
Comment 7•10 years ago
|
||
Thanks for filing this. Due to resource constraints we are closing bugs which we won't realistically be able to fix. If you have a patch that applies to this bug please reopen. For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•