633748 - JavaScript Error: "tabview error: paint"

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Tim Taubert [:ttaubert] (inactive)]

window.innerWidth is sometimes too small in TabCanvas._drawWindow(). Subtracting the scrollbar width from that causes the maxWidth value to become less than one. Until we have a better method (bug 631593) to retrieve the actual scrollbar width we should just prevent maxWidth from going below one to eliminate ugly js console errors.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 511970 [details] [diff] [review]
patch v1

Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=e4fface07745

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 511970 [details] [diff] [review]
patch v1

One question: is 25 really a good guess across platforms?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #3)
> One question: is 25 really a good guess across platforms?

Well, at least the test for bug 594958 on all platforms ensures that no black border is on the right. So that might be at least a good guess for default settings.

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 511970 [details] [diff] [review]
patch v1

Good detail

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 511970 [details] [diff] [review]
patch v1

a=beltzner

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/796db5299d3d

Comment 9

[Tracy Walker [:tracy]]

verified with minefield build of 20110217