JavaScript Error: "tabview error: paint"

VERIFIED FIXED in Firefox 4.0b12

Status

defect
P2
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 4.0b12
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

window.innerWidth is sometimes too small in TabCanvas._drawWindow(). Subtracting the scrollbar width from that causes the maxWidth value to become less than one. Until we have a better method (bug 631593) to retrieve the actual scrollbar width we should just prevent maxWidth from going below one to eliminate ugly js console errors.
Posted patch patch v1 (obsolete) — Splinter Review
Attachment #511970 - Flags: review?(ian)
Comment on attachment 511970 [details] [diff] [review]
patch v1

One question: is 25 really a good guess across platforms?
Attachment #511970 - Flags: feedback+
(In reply to comment #3)
> One question: is 25 really a good guess across platforms?

Well, at least the test for bug 594958 on all platforms ensures that no black border is on the right. So that might be at least a good guess for default settings.
Comment on attachment 511970 [details] [diff] [review]
patch v1

Good detail
Attachment #511970 - Flags: review?(ian) → review+
Attachment #511970 - Flags: approval2.0?
Priority: -- → P2
Comment on attachment 511970 [details] [diff] [review]
patch v1

a=beltzner
Attachment #511970 - Flags: approval2.0? → approval2.0+
Attachment #511970 - Attachment is obsolete: true

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/796db5299d3d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.