No focus ring displayed on Add-ons Manager when I navigate with Tab key

RESOLVED INACTIVE

Status

()

Toolkit
Add-ons Manager
RESOLVED INACTIVE
7 years ago
4 days ago

People

(Reporter: Alice0775 White, Assigned: peregrino)

Tracking

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(3 attachments)

(Reporter)

Description

7 years ago
Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110213 Firefox/4.0b12pre ID:20110213030344

No focus ring displayed when I navigate with Tab key.


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open ( http://www.blic.rs/Vesti/Svet/222903/Bugari-i-Rusi-naredne-nedelje-o-ceni-nuklearke-Belene )
3.

Actual Results:
 No focus ring displayed when I navigate with Tab key.
 Focus ring is provided for a link and a button only.

Expected Results:
 Focus ring should be provoded when I navigate with Tab key.
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?
Summary: No focus ring displayed when I navigate with Tab key → No focus ring displayed on Add-ons Manager when I navigate with Tab key
(Reporter)

Comment 1

7 years ago
Sorry Wrong STR

Steps to Reproduce:
1. Start Minefield with new profile
2. Open Add-ons Manager
3. Press Tab key and repeat
A couple of elements are involved here, like the category and all listbox entries. It's kinda hard to predict where the focus currently is positioned at.
Not a blocker, though I agree that it's annoying.
blocking2.0: ? → -
This doesn't seem to be a regression from bug 563912 as far as I can see, and I can see focus rings on the buttons at least.
No longer blocks: 563912
Created attachment 8434386 [details] [diff] [review]
WIP

Since fixing bug 1014698 on the in-content preferences seemed pretty similar to this one, I tried to apply the same solution here. Now, I'm not quite convinced the styles for the focused category are good-looking. Is there any recommendation for the styles?
Created attachment 8434388 [details]
screenshot with styles applied
Created attachment 8436420 [details]
Screenshot - Windows 8

Windows 8 uses square corners, which makes this look better.
Assignee: nobody → colmeiro
Status: NEW → ASSIGNED
Comment on attachment 8434386 [details] [diff] [review]
WIP

Review of attachment 8434386 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine - though I do wish we painted the border corners better :\ I don't think we should spend too much time getting it perfect, as we'll be able to start converting about:addons to the new visual style used by about:preferences sometime in the not-too-distant future. In the mean time, this is an important accessibility improvement.

Could you also do the same for the add-ons list?
Attachment #8434386 - Flags: feedback+
I'll do the same for the add-ons list and update the patch.

Comment 10

3 years ago
The lack of a focus ring for the categories persists with the Add-ons Manager using now the new visual style from about:preferences. Is possible now to port more easily the changes made in bug 1014698?

Comment 11

4 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.