633840 - No focus ring displayed on Add-ons Manager when I navigate with Tab key

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Alice0775 White]

Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110213 Firefox/4.0b12pre ID:20110213030344

No focus ring displayed when I navigate with Tab key.


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open ( http://www.blic.rs/Vesti/Svet/222903/Bugari-i-Rusi-naredne-nedelje-o-ceni-nuklearke-Belene )
3.

Actual Results:
 No focus ring displayed when I navigate with Tab key.
 Focus ring is provided for a link and a button only.

Expected Results:
 Focus ring should be provoded when I navigate with Tab key.

Comment 1

[Alice0775 White]

Sorry Wrong STR

Steps to Reproduce:
1. Start Minefield with new profile
2. Open Add-ons Manager
3. Press Tab key and repeat

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A couple of elements are involved here, like the category and all listbox entries. It's kinda hard to predict where the focus currently is positioned at.

Comment 3

[Mike Shaver (:shaver emeritus)]

Not a blocker, though I agree that it's annoying.

Comment 4

[Dave Townsend [:mossop]]

This doesn't seem to be a regression from bug 563912 as far as I can see, and I can see focus rings on the buttons at least.

Comment 5

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: WIP

Since fixing bug 1014698 on the in-content preferences seemed pretty similar to this one, I tried to apply the same solution here. Now, I'm not quite convinced the styles for the focused category are good-looking. Is there any recommendation for the styles?

Comment 6

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: screenshot with styles applied

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot - Windows 8

Windows 8 uses square corners, which makes this look better.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8434386 [details] [diff] [review]
WIP

Review of attachment 8434386 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine - though I do wish we painted the border corners better :\ I don't think we should spend too much time getting it perfect, as we'll be able to start converting about:addons to the new visual style used by about:preferences sometime in the not-too-distant future. In the mean time, this is an important accessibility improvement.

Could you also do the same for the add-ons list?

Comment 9

[Hernán Rodriguez Colmeiro (:peregrino)]

I'll do the same for the add-ons list and update the patch.

Comment 10

[Carlos [nohamelin]]

The lack of a focus ring for the categories persists with the Add-ons Manager using now the new visual style from about:preferences. Is possible now to port more easily the changes made in bug 1014698?

Comment 11

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.