633895 - /bin/sh: syntax error at line 4: `dirs=$' unexpected in services/sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ginn Chen]

/bin/sh in Solaris doesn;'t support
dirs=$$(find * -type d);

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 512102 [details] [diff] [review]
patch

Ginn: I've kicked off a Linux try build with this change. It looks fine, but of course needs to be tested. I won't get the results before I hit the sack, so I'll take care of the rest tomorrow.

I don't have any Solaris build boxes available to me, so please verify that this change results in a Minefield build with working Sync.

Comment 3

[Ginn Chen]

On OpenSolaris, /bin/sh is ksh93, which accepts $$(find ...).

I added echo $$d; in the loop and verified
dirs=$$(find * -type d);
and
dirs=`find * -type d`;
get the same results.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 512102 [details] [diff] [review]
patch

Try build is

http://tbpl.mozilla.org/?tree=MozillaTry&rev=14bdee9acdfd

Builds fine on my machine. When that try build is green, you can haz review.


You might be interested in the following. Presumably they will also fail on Solaris:

$ fgrep "\$\$(" **/*.in

build/unix/elfhack/Makefile.in:	[ $$(objdump -R $@.bak | wc -l) -gt $$(objdump -R $@ | wc -l) ]
ipc/ipdl/Makefile.in:ALL_IPDLSRCS += $$(IPDLSRCS:%=$(IPDLDIR)/%)
ipc/ipdl/Makefile.in:PROTOCOLS += $$(IPDLSRCS)

Comment 5

[Richard Newman [:rnewman]]

Try is green.

Comment 6

[Mike Connor [:mconnor]]

Ginn, are you still needing this for Fx4?  If so, please request approval!

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 512102 [details] [diff] [review]
patch

a=mconnor

Comment 8

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/e47efbba2fef