Closed Bug 633895 Opened 9 years ago Closed 9 years ago

/bin/sh: syntax error at line 4: `dirs=$' unexpected in services/sync

Categories

(Firefox :: Sync, defect)

All
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

/bin/sh in Solaris doesn;'t support
dirs=$$(find * -type d);
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #512102 - Flags: review?(rnewman)
Comment on attachment 512102 [details] [diff] [review]
patch

Ginn: I've kicked off a Linux try build with this change. It looks fine, but of course needs to be tested. I won't get the results before I hit the sack, so I'll take care of the rest tomorrow.

I don't have any Solaris build boxes available to me, so please verify that this change results in a Minefield build with working Sync.
On OpenSolaris, /bin/sh is ksh93, which accepts $$(find ...).

I added echo $$d; in the loop and verified
dirs=$$(find * -type d);
and
dirs=`find * -type d`;
get the same results.
Comment on attachment 512102 [details] [diff] [review]
patch

Try build is

http://tbpl.mozilla.org/?tree=MozillaTry&rev=14bdee9acdfd

Builds fine on my machine. When that try build is green, you can haz review.


You might be interested in the following. Presumably they will also fail on Solaris:

$ fgrep "\$\$(" **/*.in

build/unix/elfhack/Makefile.in:	[ $$(objdump -R $@.bak | wc -l) -gt $$(objdump -R $@ | wc -l) ]
ipc/ipdl/Makefile.in:ALL_IPDLSRCS += $$(IPDLSRCS:%=$(IPDLDIR)/%)
ipc/ipdl/Makefile.in:PROTOCOLS += $$(IPDLSRCS)
Attachment #512102 - Flags: review?(rnewman) → review+
Try is green.
Component: Firefox Sync: Backend → Firefox Sync: Build
QA Contact: sync-backend → sync-build
Ginn, are you still needing this for Fx4?  If so, please request approval!
Attachment #512102 - Flags: approval2.0?
Comment on attachment 512102 [details] [diff] [review]
patch

a=mconnor
Attachment #512102 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/e47efbba2fef
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Component: Firefox Sync: Build → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.