Closed Bug 633913 Opened 13 years ago Closed 12 years ago

Add a pseudo-class to access indeterminate <progress> elements


(Core :: DOM: Core & HTML, defect)

Not set





(Reporter: mounir, Assigned: mounir)



(Keywords: dev-doc-complete, html5)


(1 file, 1 obsolete file)

According to the specs, a progress element can be indeterminate. It might be interesting to let the authors access indeterminate progress elements given that they might want to style them differently.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #512129 - Flags: review?(jonas)
For what it's worth, this is going to conflict with the various patches in bug 	313351, and bug 598833.  I can handle merging if this lands first, I guess, but just wanted to give you a heads-up.
And wait.  Why do you need that AfterSetAttr gunk?
(In reply to comment #3)
> And wait.  Why do you need that AfterSetAttr gunk?

Eh, I don't indeed: indeterminate state only depends on one attribute's value. This should make the merge issue smaller. Thanks for the noticing ;)
Attached patch Patch v1.1Splinter Review
Updated patch. Boris, you won the right to review it :)
Attachment #512129 - Attachment is obsolete: true
Attachment #512147 - Flags: review?(bzbarsky)
Attachment #512129 - Flags: review?(jonas)
Comment on attachment 512147 [details] [diff] [review]
Patch v1.1

s/determinated/determined/ and looks good.  And yeah, now you're only conflicting with code I haven't written yet.  ;)
Attachment #512147 - Flags: review?(bzbarsky) → review+
Blocks: 598833
Whiteboard: [can land][post-2.0]
Whiteboard: [can land][post-2.0]
Whiteboard: [ready to land][waits for dependencies]
Blocks: 634088
I wonder if we shouldn't use :-moz-indeterminate instead of :indeterminate here.
I've open a bug against HTML specs to have it specified:

Though, I should probably send an email somewhere to ask for a better specification of the indeterminate pseudo-class in CSS. I wonder if CSS3-UI couldn't simply override what Selectors say (it doesn't really say anything actually, the only specs is a Note....).
David, what is your feeling about comment 7? Boris is ok to not prefix it (according to our IRC conversation).
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Depends on: 655860
Backed out in to resolve bug 655860.
Resolution: FIXED → ---
The regression wasn't caused by these patches. Re-landed:
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
I'm ok with unprefixed.
No longer depends on: 655860

It looks like the :indeterminate pseudo-class is not being triggered on <progress> elements with no value.

Just try opening this page:

in Firefox and then in Chrome.

In Chrome, you'll get animation for indeterminate progress bars.

In Firefox, the bars are just staying solid.

Also, when you click "inspect element" in Chrome, you'll see that the progress bar has the :indeterminate pseudo-class selected.

In Firefox, it doesn't.

Oh, I'm sorry, it looks like :indeterminate is in deed being triggered in CSS, so probably the animation isn't done quite right. I'll check it out further.

You need to log in before you can comment on or make changes to this bug.