633924 - MethodJIT broken on mingw-w64 win64 build

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

It's mostly broken because we share assembly parts with UNIX 64-bit builds, but win64 ABI is different, so we should use the same assembly as MSVC builds do. Required changes include:

- TrampolineMingwX64.s
Although we could use inline assembly here, it's easier to keep in sync with masm version if it's in separated file. It's in fact just ported masm assembly (in simmilar way to xpcom/reflect/xptcall/src/md/win32/xptcinvoke_asm_x86_64_gnu.s). A nice trick for review, to see the real differences between these files, is:

$ sed 's/;/#/g' TrampolineMasmX64.asm >/tmp/as
$ diff -u /tmp/asm TrampolineMingwX64.s

- Makefile.in
Added new assembly to the build process

- MachineRegs.h
Changed ifdefs that should be ABI-specific instead of compiler-specific

- MethodJIT.cpp
Changed ifdefs to tread mingw and msvc win64 build the same way

Comment 1

[Jacek Caban]

Thanks for the review, pushed to t-m:

http://hg.mozilla.org/tracemonkey/rev/977bd127e9f3

Comment 2

[Jacek Caban]

Merged to m-c:

http://hg.mozilla.org/mozilla-central/rev/977bd127e9f3