Closed
Bug 633942
Opened 13 years ago
Closed 13 years ago
add debug logging for OOPP model negotiation
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
4.88 KB,
patch
|
Details | Diff | Splinter Review |
We could use some basic logging for OOPP model negotiation.
Attachment #512156 -
Flags: review?(benjamin)
Comment 2•13 years ago
|
||
Comment on attachment 512156 [details] [diff] [review] fix v1.0 I really don't like printfs which we can't turn off. Can you hide them behind an envvar or something? r=me with that change
Attachment #512156 -
Flags: review?(benjamin) → review+
Attachment #512156 -
Attachment is obsolete: true
Attachment #512168 -
Flags: approval2.0+
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/aa5cc00bf99a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
backed out due to 64-bit mac opt orange, though it really doesn't look like this patch is to blame http://hg.mozilla.org/mozilla-central/rev/0c91682d0629 http://hg.mozilla.org/mozilla-central/rev/51b556687380
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•13 years ago
|
||
Comment on attachment 512168 [details] [diff] [review] fix v1.1 Removing approval; re-request if you think we should take this.
Attachment #512168 -
Flags: approval2.0+
I no longer think this is necessary for Firefox 4 right now, if we have further problems we can take it in a later release.
Comment 8•13 years ago
|
||
We already landed this part of another patch
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•