add debug logging for OOPP model negotiation

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Josh Aas, Unassigned)

Tracking

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.88 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
We could use some basic logging for OOPP model negotiation.
(Reporter)

Comment 1

6 years ago
Created attachment 512156 [details] [diff] [review]
fix v1.0
Attachment #512156 - Flags: review?(benjamin)
Comment on attachment 512156 [details] [diff] [review]
fix v1.0

I really don't like printfs which we can't turn off. Can you hide them behind an envvar or something? r=me with that change
Attachment #512156 - Flags: review?(benjamin) → review+
(Reporter)

Comment 3

6 years ago
Created attachment 512168 [details] [diff] [review]
fix v1.1
Attachment #512156 - Attachment is obsolete: true
(Reporter)

Updated

6 years ago
Attachment #512168 - Flags: approval2.0+
(Reporter)

Comment 4

6 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/aa5cc00bf99a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

6 years ago
backed out due to 64-bit mac opt orange, though it really doesn't look like this patch is to blame

http://hg.mozilla.org/mozilla-central/rev/0c91682d0629
http://hg.mozilla.org/mozilla-central/rev/51b556687380
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 512168 [details] [diff] [review]
fix v1.1

Removing approval; re-request if you think we should take this.
Attachment #512168 - Flags: approval2.0+
(Reporter)

Comment 7

6 years ago
I no longer think this is necessary for Firefox 4 right now, if we have further problems we can take it in a later release.
(Reporter)

Updated

6 years ago
Assignee: joshmoz → nobody
We already landed this part of another patch
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.