Test failure in testTabRestoration.js | could not find element ID: history/localization

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: aaronmt, Assigned: aaronmt)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(2 attachments)

(Assignee)

Updated

7 years ago
Summary: Test failure in testTabRestoration | could not find element ID: history/localization → Test failure in testTabRestoration.js | could not find element ID: history/localization
(Assignee)

Comment 1

7 years ago
Created attachment 512288 [details] [diff] [review]
Patch v1 - (default) [checked-in]

It seems like on slower systems, we need to a waitForElement, looks like waitForPageLoad is insufficient on its own on exit of PB mode (is this needed with local pages?). Not sure again why this is exposed now all of a sudden, as well, only Windows 7. Inserting a waitForElement is giving me passes on qa-horus
Attachment #512288 - Flags: review?(hskupin)
Comment on attachment 512288 [details] [diff] [review]
Patch v1 - (default) [checked-in]

Good catch! The underlying issue here is, that when leaving PB mode we load the pages from the bfcache. WaitForPageLoad cannot handle that at the moment. See the back and forward button test. Please land on all branches.
Attachment #512288 - Flags: review?(hskupin) → review+
(Assignee)

Comment 3

7 years ago
Landed as:

default - http://hg.mozilla.org/qa/mozmill-tests/rev/fa1542a55fe1
1.9.2 - http://hg.mozilla.org/qa/mozmill-tests/rev/937d0ba8cc0b
1.9.1 - http://hg.mozilla.org/qa/mozmill-tests/rev/6d3ed5c83bfa
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Attachment #512288 - Attachment description: Patch v1 - (default) → Patch v1 - (default) [checked-in]
(Assignee)

Comment 4

7 years ago
Created attachment 512483 [details] [diff] [review]
Patch v2 Follow-up correction - (default) [checked-in]

The new addition was placed in the wrong spot, but it was passing. It should really be in the spot after the exit of private browsing patch.
Attachment #512483 - Flags: review?(hskupin)
(Assignee)

Updated

7 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

7 years ago
Attachment #512483 - Attachment description: Patch v2 - (default) → Patch v2 Follow-up correction - (default)
Attachment #512483 - Flags: review?(hskupin) → review+
(Assignee)

Comment 5

7 years ago
Correction follow-up landed as:

http://hg.mozilla.org/qa/mozmill-tests/rev/cb9858a4e815
http://hg.mozilla.org/qa/mozmill-tests/rev/fff0b8361416
http://hg.mozilla.org/qa/mozmill-tests/rev/b24479a1b338
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Attachment #512483 - Attachment description: Patch v2 Follow-up correction - (default) → Patch v2 Follow-up correction - (default) [checked-in]
You need to log in before you can comment on or make changes to this bug.