Closed Bug 634009 Opened 9 years ago Closed 9 years ago

[regression] Gestures (two fingers up or down) open links

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

ARM
Android
defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: tarend, Assigned: wesj)

Details

(Whiteboard: [fennec-checkin-postb5])

Attachments

(1 file)

Similar to Bug 633539 but for two finger gestures

(1) On a loaded web page swipe up or down with two fingers tapping on a link

Result: page scrolls to the top or bottom but immediately navigates to the link you tapped when starting the gesture
Expected: scroll to top or bottom but don't follow a link

This is related to Bug 630594 and Bug 633539
Attached patch Patch v1Splinter Review
This is kinda the dumb patch. Copied from _pinchStart. Not sure if there is a cleaner way to do this that doesn't send CancelTouchSequence all the time.

This seems to work, but I'm clobbering again for better testing...
Attachment #512223 - Flags: review?(mbrubeck)
Attachment #512223 - Flags: review?(mbrubeck) → review+
Assignee: nobody → wjohnston
tracking-fennec: ? → 2.0+
Whiteboard: [fennec-checkin-postb5]
Pushed: http://hg.mozilla.org/mobile-browser/rev/48bde5d94140
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.