JIT tests should have a timeout parameter

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This is useful for debugging infinite loops and for testing with GC zeal.
(Assignee)

Comment 1

6 years ago
Created attachment 512287 [details] [diff] [review]
patch

I copied this code from jstests.py. I guess eventually this infrastructure should be shared.
Assignee: general → wmccloskey
Status: NEW → ASSIGNED
Attachment #512287 - Flags: review?(dmandelin)
Attachment #512287 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 527832 [details] [diff] [review]
patch v2

I never felt like this patch was really done. This new one makes it a lot easier to do GC zeal testing. It adds a --args option to jit-tests so you can specify -Z. And for both jit-tests and jstests, it prints timeout failures separate from other kinds of failures. This makes it much easier to see if anything actually went wrong.
Attachment #512287 - Attachment is obsolete: true
Attachment #527832 - Flags: review?(dmandelin)
Attachment #527832 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/tracemonkey/rev/848855c35e27
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/848855c35e27
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 659790
You need to log in before you can comment on or make changes to this bug.