Closed Bug 634090 Opened 11 years ago Closed 10 years ago

JIT tests should have a timeout parameter

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: billm, Assigned: billm)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

This is useful for debugging infinite loops and for testing with GC zeal.
Attached patch patch (obsolete) — Splinter Review
I copied this code from jstests.py. I guess eventually this infrastructure should be shared.
Assignee: general → wmccloskey
Status: NEW → ASSIGNED
Attachment #512287 - Flags: review?(dmandelin)
Attachment #512287 - Flags: review?(dmandelin) → review+
Attached patch patch v2Splinter Review
I never felt like this patch was really done. This new one makes it a lot easier to do GC zeal testing. It adds a --args option to jit-tests so you can specify -Z. And for both jit-tests and jstests, it prints timeout failures separate from other kinds of failures. This makes it much easier to see if anything actually went wrong.
Attachment #512287 - Attachment is obsolete: true
Attachment #527832 - Flags: review?(dmandelin)
Attachment #527832 - Flags: review?(dmandelin) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 659790
You need to log in before you can comment on or make changes to this bug.