Port |Bug 633638 - Need a way to cancel PlacesUtils::asyncGetBookmarkIds request| to SeaMonkey

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(blocking-seamonkey2.1 needed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Assignee: nobody → sgautherie.bz

Comment 1

6 years ago
Serge are you working on this, if so could you update the status or reset the assigned?
blocking-seamonkey2.1: ? → needed
(Assignee)

Comment 2

6 years ago
Created attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]
Attachment #517729 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Whiteboard: [good first bug] [FF2SM]

Comment 3

6 years ago
Comment on attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]

>   onClick: function PSB_onClick(aEvent)
>   {
>-    if (aEvent.button == 0 && !this._ignoreClicks)
>+    // Ignore clicks on the star while we update its state.
>+    if (aEvent.button == 0 && !this._pendingStmt) {
>       PlacesCommandHook.bookmarkCurrentPage(this._itemIds.length > 0);
>   },

r=me with extra { sorted.
Attachment #517729 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]

http://hg.mozilla.org/comm-central/rev/7368388813b0
Av1, with comment 3 suggestion(s).
Attachment #517729 - Attachment description: (Av1) Just copy it → (Av1) Just copy it [Checked in: See comment 4]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.