Last Comment Bug 634244 - Port |Bug 633638 - Need a way to cancel PlacesUtils::asyncGetBookmarkIds request| to SeaMonkey
: Port |Bug 633638 - Need a way to cancel PlacesUtils::asyncGetBookmarkIds requ...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 633638
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-15 05:20 PST by Serge Gautherie (:sgautherie)
Modified: 2011-03-13 11:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
needed


Attachments
(Av1) Just copy it [Checked in: See comment 4] (3.24 KB, patch)
2011-03-08 06:47 PST, Serge Gautherie (:sgautherie)
iann_bugzilla: review+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2011-02-15 05:20:42 PST

    
Comment 1 Ian Neal 2011-03-08 06:29:04 PST
Serge are you working on this, if so could you update the status or reset the assigned?
Comment 2 Serge Gautherie (:sgautherie) 2011-03-08 06:47:54 PST
Created attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]
Comment 3 Ian Neal 2011-03-13 10:02:07 PDT
Comment on attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]

>   onClick: function PSB_onClick(aEvent)
>   {
>-    if (aEvent.button == 0 && !this._ignoreClicks)
>+    // Ignore clicks on the star while we update its state.
>+    if (aEvent.button == 0 && !this._pendingStmt) {
>       PlacesCommandHook.bookmarkCurrentPage(this._itemIds.length > 0);
>   },

r=me with extra { sorted.
Comment 4 Serge Gautherie (:sgautherie) 2011-03-13 11:49:20 PDT
Comment on attachment 517729 [details] [diff] [review]
(Av1) Just copy it
[Checked in: See comment 4]

http://hg.mozilla.org/comm-central/rev/7368388813b0
Av1, with comment 3 suggestion(s).

Note You need to log in before you can comment on or make changes to this bug.