634277 - Windows signatures without symbols may differ in case, affecting the prefix/skiplists

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Benjamin Smedberg]

https://crash-stats.mozilla.com/report/index/96feac8f-c46e-4c2b-853d-05f402110215
mozalloc_abort(char const* const) | mozcrt19.dll@0x1327f | nsCycleCollectorGCHookRunnable::Run()

https://crash-stats.mozilla.com/report/index/be3ce273-1c04-4bdb-808e-9078b2110215
mozalloc_abort(char const* const) | MOZCRT19.dll@0x1327f

https://crash-stats.mozilla.com/report/index/80ea101d-cd81-4508-b9e2-4ac312110215
mozalloc_abort(char const* const) | MOZCRT19.DLL@0x1327f

These signatures should really all be the same.

I think that the "easy" fix here would be to normalize DLL names to lowercase only for Windows in the processor. Ted, does that sound reasonable?

I'd like this for 3.7.7 if possible.

Comment 1

[Benjamin Smedberg]

I guess I mean 1.7.7? The one in 2 weeks or so.

Comment 2

[Laura Thomson :laura]

Probably fine - lars?

Comment 3

[K Lars Lohn [:lars] [:klohn]]

It looks pretty trivial.  There is a function for the normalization of signatures.  In the case where is has to use the module name followed by the address, I could easily force the module name to lower case.

Comment 4

[(not currently active) Ted Mielczarek]

Ah, I forgot that Socorro is responsible for pasting together the module name + address in this case. Yeah, it should be fine to lowercase that only on Windows.

Comment 5

[K Lars Lohn [:lars] [:klohn]]

the aforementioned function has no knowledge of the os that spawned the crash.  Is it safe to assume that if the module has the substring ".DLL" within, it is from windows and should be forced into lowercase?  

The other option is to include the os in the parameters of the function.  I am loath to change the api in a long chain of function calls so that the os value can tag along for this one case.

Comment 6

[Benjamin Smedberg]

Yeah, I think that for now .dll and .exe should be fine. Of course you'll need a case-insensitive search ;-)

Comment 7

[timeless]

quicktime and reader use screwy extensions (qts, api), so do IMEs (ime), localization (mui, nls, nlp), printers/audio filters (drv, ax), that excludes fonts (ttf, otf, ...), screen savers (scr - i hope never to see them in our process), control panels (cpl - the bluetooth tray item seems to have its loaded, again, it'd be scary to see but it might happen if we do something w/ bt).

a scary one i have is igfxrenu.lrc - i think this is a language resource

i have msacm32.drv, winspool.drv, wdmaud.drv, SortDefault.nls, locale.nls, index.dat,  loaded in a plugin-container.exe

the following are in firefox.exe:
{6AF0698E-D558-4F6E-9B3C-3716689AF493}.2.ver0x000000000000000c.db			
{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi			
{AFBF9F1A-8EE8-4C77-AF34-C647E37CA0D9}.1.ver0x000000000000000b.db			
{DDF571F2-BE98-426D-8288-1A9A39C3FDA2}.2.ver0x0000000000000001.db			
cookies.sqlite-shm			
cversions.2.db			
locale.nls			
omni.jar			
places.sqlite-shm			
SortDefault.nls			
startupCache.4.little			
StaticCache.dat			
winspool.drv	
XUL.mfl			

I don't have this one loaded in firefox/plugin-container today, but i expect it to be loaded occasionally:
mpg2splt.ax	DirectShow MPEG-2 Splitter.	6.6.7600.16648	(Verified) Microsoft Windows
msdxm.tlb	Windows Media Player 6.4 Type Library	12.0.7600.16385	(Verified) Microsoft Windows
ksproxy.ax	WDM Streaming ActiveMovie Proxy	6.1.7600.16385	(Verified) Microsoft Windows
could you just look through the list and lowercase everything if you find one .exe in the list?

Comment 8

[Laura Thomson :laura]

To clarify scope:
If we see an .exe in the list, assume windows and canonicalize everything to lower case.  

Is that all that is required here?

Comment 9

[Scoobidiver (away)]

In reply to comment 8
> Is that all that is required here?
That request differs from the original one.
It won't lower-case MOZCRT19.dll in bp-fa3cf645-e391-4c78-8037-b39782110215

It would be instead (see comment 6):
If we see an .exe or .dll in the list, assume windows and canonicalize everything to lower case.

Comment 10

[K Lars Lohn [:lars] [:klohn]]

this is checked into 1.7.7 trunk r2959.