Closed
Bug 634282
Opened 13 years ago
Closed 8 years ago
mozjs.dll/js3250.dll has no version information
Categories
(Firefox Build System :: General, defect)
Tracking
(blocking2.0 -, blocking1.9.2 needed, status1.9.2 wanted, blocking1.9.1 needed, status1.9.1 wanted)
People
(Reporter: dveditz, Assigned: khuey)
References
Details
Attachments
(1 obsolete file)
Most of our windows executables have version information, but js3250.dll does not. These versions can be an important diagnostic tools as seen in bug 633869, and all our other dlls seem to have them.
|
Assignee | |
Comment 1•13 years ago
|
||
What is js3250.dll? We don't have this on trunk.
|
||
Updated•13 years ago
|
blocking2.0: ? → -
|
|
Assignee | |
Comment 2•13 years ago
|
||
I assume this is a predecessor to mozjs.dll, which also doesn't have version info.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Renomming for blocking per comment 2.
Assignee: nobody → khuey
blocking2.0: - → ?
Summary: js3250.dll has no version information → mozjs.dll/js3250.dll has no version information
|
Reporter | |
Comment 4•13 years ago
|
||
In earlier versions (checked 3.0.x and 3.5.x) this dll had a version, but it was incorrectly frozen as "4.0.0.0". I suppose <blank> is no less informative and definitely less misleading, but a real version would be even better. (this library is called mozjs.dll in Firefox 4, still with no version)
|
|
||
Comment 5•13 years ago
|
||
I'm still not going to block on it. It's not a regression, and despite the possible utility in investigating frakenbuilds it's not a big deal.
blocking2.0: ? → -
|
|
Assignee | |
Comment 6•13 years ago
|
||
js/src doesn't have MOZ_WIDGET_TOOLKIT.
Attachment #512501 -
Flags: review?(ted.mielczarek)
|
||
Updated•13 years ago
|
Attachment #512501 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #512501 -
Flags: approval2.0?
Attachment #512501 -
Flags: approval1.9.2.15?
Attachment #512501 -
Flags: approval1.9.1.18?
|
|
||
Updated•13 years ago
|
Attachment #512501 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Comment on attachment 512501 [details] [diff] [review] Patch So, this won't work, because js/src/ doesn't have a config/buildid or a config/milestone.txt. Fixing this properly would probably require changes to the automation that bumps version numbers too :-/
Attachment #512501 -
Attachment is obsolete: true
Attachment #512501 -
Flags: approval1.9.2.15?
Attachment #512501 -
Flags: approval1.9.1.18?
|
|
Reporter | |
Updated•13 years ago
|
blocking1.9.1: ? → needed
blocking1.9.2: ? → needed
status1.9.1:
--- → wanted
status1.9.2:
--- → wanted
|
||
Comment 8•13 years ago
|
||
Comment on attachment 512501 [details] [diff] [review] Patch (bookkeeping)
Attachment #512501 -
Flags: approval2.0+
On crash reports I sort modules by version to make third-party binaries stand out. khuey, any plans to revisit this?
Flags: needinfo?(khuey)
|
|
Assignee | |
Comment 12•8 years ago
|
||
mozjs.dll disappeared into xul.dll at some point, so this got fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•