Right now, on Win32 you cannot easily build PSM with the BUILD_PSM variable defined. the mozilla client breaks because it trys to include several security headers files and it can't find them. This is because it's only looking in dist\include for header files and the security header files are located in dist\include\security
not sure why this went to mstoltz. I meant to send it to the psm-glue owner. guessing security crypto?
Assignee: mstoltz → ddrinan
Component: Security: General → Security: Crypto
QA Contact: ckritzer → junruh
turns out this fix is trivial. It's just a makefile change: Index: makefile.win =================================================================== RCS file: /cvsroot/mozilla/extensions/psm-glue/src/makefile.win,v retrieving revision 1.10 diff -u -r1.10 makefile.win --- makefile.win 2000/12/06 23:43:53 1.10 +++ makefile.win 2000/12/20 21:12:06 @@ -37,7 +37,7 @@ LINCS = $(LINCS) \ -I$(PUBLIC) \ - -I$(XPDIST)/public/security \ + -I$(XPDIST)/include/security \ $(NULL) LLIBS = \ Pav can you review this? I think you are listed as the psm-glue owner on mozilla!
Why is this change needed? The intention was if PSM/NSS was not being built with Mozilla, then PSM glue should not be build either since PSM glue is just a layer that depends on and uses PSM/NSS. Is there a problem in Mozilla if PSM glue is not built that we did not think of?
this change is needed because currently it is not possible on windows to get a build to actually build if you define BUILD_PSM. We always die in psm-glue/src because it can't find the security header files (like rsrcids.h) We've all been manually copying all the header files in dist\include\security into dist\include in order to get mozilla to build. That's because there's a bug in this makefile where we are looking for public/security instead of include/security. Again this is for mozilla developers trying to build with BUILD_PSM defined in their environment. Do that and run nmake /f client.mak build_all and your build will fail.
When I build mozilla (my tree is a few days old), I'm able to build psm-glue just fine. All the security header files are in the dist/public/include directory. Let me update my tree to see what has changed to cause this problem.
The previous comment should read: "...All the security header files are in the dist/public/security directory...
There have been a lot of postings in the builds newsgroups about folks having to copy security header files into dist\include. And we had some friends on the East coast that have the same problem. I ran into it over the last couple days while working on some psm-glue bugs involving the lock state in the browser window. I'd try a clobber build so you are starting from scratch. We all break at the same spot, when psm-glue attempts to include rsrcids.h it can't find that header file.
Interesting. I don't have a dist\public directory at all. Only a dist\include directory. And security is underneath that. I wonder if there is another flag that needs to be set to force security to get rebuilt under public instead of include.
This is very strange behaviour indeed. I'm running a clobber build at the moment and I should know something soon.
mscott, please check that the file mozilla/security/makefile.win is from the tip with a rev of 1.3. If it is from the SECURITY_CLIENT_BRANCH, then I would suggest that you remove the mozilla/security directory and pull the tree again via client.mak. You should be able to do nmake -f client.mak pull_psm.
It is indeed from the branch and not the tip. I'll try repulling mozilla/security. That must be the problem some of us must be having....Thanks for the detective work!
It also happens for my build! I manually copy all the header files and it can build. However, I suspect that is the right way.
What's going on about this bug???
PSM 2.0 is now part of the mozilla and commercial builds and has fixed alot of UI and ssl bugs that were in PSM 1.X. I'm doing a mass setting of bugs to be FIXED. If you believe that I've closed a bug in error, please re-open it. Thanks.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.1
Mass changing Security:Crypto to PSM
You need to log in before you can comment on or make changes to this bug.