Closed Bug 634395 Opened 9 years ago Closed 9 years ago
Don't trigger Trigger
Bouncer Check if push to mirrors fails
In the current implementation ScriptFactory doesn't have haltOnFailure set for run_script step, so TriggerBouncerCheck is triggered even if the previous step fails.
Comment on attachment 515595 [details] [diff] [review] Add haltOnFailure parameter to ScriptFactory In an effort to keep ScriptFactory small and simple I'd suggest that we *always* haltOnFailure if the script fails -- I can't think of a case where this would be undesired.
Attachment #515595 - Flags: review?(bhearsum) → review-
(In reply to comment #2) > In an effort to keep ScriptFactory small and simple I'd suggest that we > *always* haltOnFailure if the script fails -- I can't think of a case where > this would be undesired. Sounds quite reasonable.
Attachment #515603 - Flags: review?(bhearsum) → review+
Comment on attachment 515603 [details] [diff] [review] Always haltOnFailure in ScriptFactory http://hg.mozilla.org/build/buildbotcustom/rev/400e949a156f
Attachment #515603 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.