Closed Bug 634395 Opened 9 years ago Closed 9 years ago

Don't trigger TriggerBouncerCheck if push to mirrors fails

Categories

(Release Engineering :: General, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [releases][automation])

Attachments

(1 file, 1 obsolete file)

In the current implementation ScriptFactory doesn't have haltOnFailure set for run_script step, so TriggerBouncerCheck is triggered even if the previous step fails.
Attachment #515595 - Flags: review?(bhearsum)
Comment on attachment 515595 [details] [diff] [review]
Add haltOnFailure parameter to ScriptFactory

In an effort to keep ScriptFactory small and simple I'd suggest that we *always* haltOnFailure if the script fails -- I can't think of a case where this would be undesired.
Attachment #515595 - Flags: review?(bhearsum) → review-
(In reply to comment #2)
> In an effort to keep ScriptFactory small and simple I'd suggest that we
> *always* haltOnFailure if the script fails -- I can't think of a case where
> this would be undesired.

Sounds quite reasonable.
Attachment #515595 - Attachment is obsolete: true
Attachment #515603 - Flags: review?(bhearsum)
Attachment #515603 - Flags: review?(bhearsum) → review+
Comment on attachment 515603 [details] [diff] [review]
Always haltOnFailure in ScriptFactory

http://hg.mozilla.org/build/buildbotcustom/rev/400e949a156f
Attachment #515603 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.