634401 - Bookmark sync: use nsINavBookmarksService::moveItem, not setItemIndex

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

From bug 626341 comment 18:
> Yes, setItemIndex is a sucky method, it's faster than moveItem (we use it
> for sorting) but can cause any sort of issues if it doesn't sort all of
> the children of a folder, because it's point-n-shoot like Duck Hunt game.
> Unfortunately we missed the train to drop it, but I'd guess we can still
> mark it as deprecated now and fix sorting in FX5.

Comment 1

[Philipp von Weitershausen [:philikon]]

Marco has a first patch in bug 626341, but I asked him to split the Sync portion off and attach it here, particularly because we would have to land this in 1.6.x as well.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

good, It could even be simpler to move along with splitted patches. I have a hardblocker to fix first, but won't take long.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

This is the basic safe approach discussed, could be done in a more efficient way, but I don't feel challenging reparenting now.
I've run tests in services/sync/tests/unit/ and I've not noticed any failure.

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 512676 [details] [diff] [review]
patch v1.0

I can land this in fx-sync and then do the merging to places/m-c once this gets approval.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, but a=beltzner

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Philipp, I leave landing and merging to you.

Comment 7

[Philipp von Weitershausen [:philikon]]

Landed in fx-sync:

1.6.x: https://hg.mozilla.org/services/fx-sync/rev/1b2c8fa446d4
default: https://hg.mozilla.org/services/fx-sync/rev/8e6ddf8717f6

Comment 8

[Philipp von Weitershausen [:philikon]]

Merged to places:
http://hg.mozilla.org/projects/places/rev/90162df434df

Comment 9

[Philipp von Weitershausen [:philikon]]

Merged to m-c:
http://hg.mozilla.org/mozilla-central/rev/90162df434df