Closed Bug 634433 Opened 15 years ago Closed 15 years ago

The link target status panel intercepts clicks on the lower left corner even when it shows up on the right side

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 646038

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

STR: 1. Load TBPL. 2. Select a job. 3. Quickly go to the lower left area to hover the "add a comment" link and click on it. The click is intercepted by the link target status panel. 4. Move the mouse a little bit around that area and try clicking again. This time it works.
I failed reproducing this a few times now, but I think that's because I set browser.overlink-delay to 500...
It also requires a fair bit of precision to hit it. Expanded STR: 1. Load TBPL, and click on a completed Linux opt mochitest - you want something with a short enough name that it doesn't wrap, so the add a comment link is not on the bottom line of the screen. 2. Hover the linked "mozilla-central/abc123" to be sure you've got the panel displaying on the left side of the page, then move up just above it, over the changeset part of the link 3. (yeah, this is an awful step) Smoothly and fairly quickly move the cursor down to where the tip of the index finger is pointing at the horizontal line in the e in the word 'comment' and click. Above there, you aren't far enough down to have the click intercepted, below there you are far enough down to move the panel to the right side, but right there (which is unfortunately where I mostly naturally wind up while aiming at a link), the panel is intercepting the click but not realizing it needs to move.
That area is right at the border of .statuspanel-inner. I haven't managed to reproduce this bug yet though.
Attached patch Patch (v1)Splinter Review
Turns out that the negative margin-top trick can easily be avoided by setting the bottom property to 0. This patch fixes this bug. Thanks to Peter for the screenshot which guided me to figure out what the cause is here.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #525133 - Flags: review?(dao)
Comment on attachment 525133 [details] [diff] [review] Patch (v1) This causes the statuspanel to overlay the add-on bar, the find bar and whatever else might be down there.
Attachment #525133 - Flags: review?(dao) → review-
I don't really see how that patch would fix this bug either. It just lets the statuspanel consume a smaller area, possibly making it harder to trigger this.
So, do you have any idea how to fix this? The code in tabbrowser.xml handles mirroring the statuspanel by listening for mouseover and dragover events, right? I can't figure out what's going wrong, but I'm willing to invest time in fixing this if you tell me how to, since I'm hitting this bug tens of times everyday. :(
I have a patch in bug 646038.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: