Port Bug 597634 [Intermittent browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org] to fix test failure from landing of bug 597584

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1b3
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
5.54 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 512716 [details] [diff] [review]
fix

After Cascaded session restore landing we have failure of some tests:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected mozilla.org
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0

This patch fixes them.
Attachment #512716 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 512716 [details] [diff] [review]
fix

>-  function waitForBrowserState(aState, aSetStateCallback) {
...
>+    waitForBrowserState(state, function() {
This doesn't look right...
Attachment #512716 - Flags: review?(neil) → review-
(Assignee)

Comment 2

7 years ago
It uses generic waitForBrowserState introduced in head.js, which is introduced by Bug 633722.
(Assignee)

Comment 3

7 years ago
Comment on attachment 512716 [details] [diff] [review]
fix

Rerequesting review.
Attachment #512716 - Flags: review- → review?(neil)

Updated

7 years ago
Attachment #512716 - Flags: review?(neil) → review+
(Assignee)

Comment 4

7 years ago
Pushed: http://hg.mozilla.org/comm-central/rev/b62ca86c48b9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.