Closed Bug 634528 Opened 13 years ago Closed 13 years ago

Port Bug 597634 [Intermittent browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org] to fix test failure from landing of bug 597584

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b3

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
After Cascaded session restore landing we have failure of some tests:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected mozilla.org
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0

This patch fixes them.
Attachment #512716 - Flags: review?(neil)
Comment on attachment 512716 [details] [diff] [review]
fix

>-  function waitForBrowserState(aState, aSetStateCallback) {
...
>+    waitForBrowserState(state, function() {
This doesn't look right...
Attachment #512716 - Flags: review?(neil) → review-
It uses generic waitForBrowserState introduced in head.js, which is introduced by Bug 633722.
Comment on attachment 512716 [details] [diff] [review]
fix

Rerequesting review.
Attachment #512716 - Flags: review- → review?(neil)
Attachment #512716 - Flags: review?(neil) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/b62ca86c48b9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.