Closed
Bug 634605
Opened 15 years ago
Closed 14 years ago
Deploy upstream fix for alwaysRun steps not getting run
Categories
(Release Engineering :: General, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
References
Details
(Whiteboard: [buildbot])
Attachments
(1 file)
|
10.95 KB,
patch
|
dustin
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
When http://trac.buildbot.net/ticket/1811 is fixed, we should take it.
|
||
Updated•15 years ago
|
Priority: -- → P4
Whiteboard: [buildbot] → [buildbot][waitingforupstream]
|
||
Comment 1•15 years ago
|
||
This just got closed upstream, by catlee..
Assignee: nobody → catlee
Whiteboard: [buildbot][waitingforupstream] → [buildbot]
|
|
Assignee | |
Comment 2•15 years ago
|
||
Dustin, what do you think about taking https://github.com/buildbot/buildbot/commit/90bd9758 as well as https://github.com/buildbot/buildbot/commit/e0279d12e2c74b3adee9e75ba9847ac950b069e5?
|
|
||
Comment 3•15 years ago
|
||
+1
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #525687 -
Flags: review?(dustin)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 525687 [details] [diff] [review]
Import upstream patches e0279d12e2c74b3adee9e75ba9847ac950b069e5, 90bd97580362af8bf7b22b939ca97fc0456023e4
Looks fine. Would it be better to land that as two commits in hg? I'll leave that to you.
Attachment #525687 -
Flags: review?(dustin) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Comment on attachment 525687 [details] [diff] [review]
Import upstream patches e0279d12e2c74b3adee9e75ba9847ac950b069e5, 90bd97580362af8bf7b22b939ca97fc0456023e4
Yeah, probably cleaner as two commits.
http://hg.mozilla.org/build/buildbot/rev/4d93829c8509
http://hg.mozilla.org/build/buildbot/rev/67a9e105b7d4
Attachment #525687 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•