Closed Bug 634637 Opened 9 years ago Closed 9 years ago

Remove make-jars.pl

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rain1, Assigned: rain1)

Details

(Whiteboard: fixed-in-bs)

Attachments

(2 files)

It isn't used anymore, nor are those config.mk definitions.

Gijs, KaiRo, timeless: I noticed it's still used in venkman's makelocalexpi.sh [1] -- however I can't tell if that file's still used, given that there's a makefile [2] that seems to do the same thing. Do you know whether it is?

[1] https://mxr.mozilla.org/comm-central/source/mozilla/extensions/venkman/xpi/makelocalexpi.sh#206
[2] https://mxr.mozilla.org/comm-central/source/mozilla/extensions/venkman/locales/Makefile.in
Attachment #512832 - Flags: review?(ted.mielczarek)
Attachment #512833 - Flags: review?(bugspam.Callek)
(In reply to comment #0)
> It isn't used anymore, nor are those config.mk definitions.
> 
> Gijs, KaiRo, timeless: I noticed it's still used in venkman's makelocalexpi.sh
> [1] -- however I can't tell if that file's still used, given that there's a
> makefile [2] that seems to do the same thing. Do you know whether it is?

I am fairly sure that Gijs (or "someone") still uses it to make venkman, however SeaMonkeys build system doesn't touch it.
Comment on attachment 512833 [details] [diff] [review]
[checked in] Kill it with fire (c-c)

Note that we reference make-jars.pl in two places in the build.

http://mxr.mozilla.org/comm-central/source/mozilla/config/config.mk?mark=418-418#415 (the second is the js/src location in mozilla-central)

Please either drop the comment (like the main m-c config.mk) or change it to reference JarMaker.py

r+ conditional on the m-c review.
Attachment #512833 - Flags: review?(bugspam.Callek) → review+
(In reply to comment #2)
> (In reply to comment #0)
> > It isn't used anymore, nor are those config.mk definitions.
> > 
> > Gijs, KaiRo, timeless: I noticed it's still used in venkman's makelocalexpi.sh
> > [1] -- however I can't tell if that file's still used, given that there's a
> > makefile [2] that seems to do the same thing. Do you know whether it is?
> 
> I am fairly sure that Gijs (or "someone") still uses it to make venkman,
> however SeaMonkeys build system doesn't touch it.

No, makelocalexpi is only used by localizers that create l10n xpis for standalone venkman. I'm not sure any such people exist (anymore), and if they do, I suspect the script has been broken for quite a while now. :-(

In any case, remove what you want to remove, is what I'd say...
Comment on attachment 512832 [details] [diff] [review]
Kill it with fire (m-c)

Feel free to land this in build-system if you'd like.
Attachment #512832 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/projects/build-system/rev/166a01bd23f5

c-c's closed right now, so I'll push whenever it reopens.
Whiteboard: fixed-in-bs
Comment on attachment 512833 [details] [diff] [review]
[checked in] Kill it with fire (c-c)

https://hg.mozilla.org/comm-central/rev/81a7fdd8816b
Attachment #512833 - Attachment description: Kill it with fire (c-c) → [checked in] Kill it with fire (c-c)
http://hg.mozilla.org/mozilla-central/rev/166a01bd23f5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.