Closed Bug 634680 Opened 12 years ago Closed 12 years ago

Intermittent browser_bug553455.js | Should be only one notification - Got 2, expected 1 Should have seen the install fail followed by Got addon-progress-notification, expected addon-install-failed-notification

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: intermittent-failure, Whiteboard: fails in test_failed_security)

Attachments

(1 file)

patch rev 1
2.56 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
mak77%bonardo.net
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297865835.1297866915.14407.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on
2011/02/16 06:17:15

s: talos-r3-leopard-046
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should be only one notification - Got 2, expected 1
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should have seen the install fail - Got addon-progress-notification, expected
addon-install-failed-notification
mak77%bonardo.net
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297871129.1297872446.1821.gz
Rev3 WINNT 5.1 mozilla-central opt test mochitest-other on 2011/02/16 07:45:29

s: talos-r3-xp-007
PROCESS-CRASH | Main app process exited normally | application crashed
(minidump found)
Thread 0 (crashed)
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should be only one notification - Got 2, expected 1
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should have seen the install fail - Got addon-progress-notification, expected
addon-install-failed-notification
margaret.leibovic%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297876639.1297877791.21605.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on
2011/02/16 09:17:19

s: talos-r3-leopard-025
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should be only one notification - Got 2, expected 1
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should have seen the install fail - Got addon-progress-notification, expected
addon-install-failed-notification
ehsan%mozilla.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297876226.1297877471.20333.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test mochitest-other on
2011/02/16 09:10:26

s: talos-r3-snow-039
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should be only one notification - Got 2, expected 1
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should have seen the install fail - Got addon-progress-notification, expected
addon-install-failed-notification
PROCESS-CRASH | Main app process exited normally | application crashed
(minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed
(minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed
(minidump found)
Thread 0 (crashed)
Whiteboard: [orange] → [orange] fails in test_failed_security
philringnalda%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297882484.1297883645.13700.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on
2011/02/16 10:54:44

s: talos-r3-leopard-003
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should be only one notification - Got 2, expected 1
TEST-UNEXPECTED-FAIL |
chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js
| Should have seen the install fail - Got addon-progress-notification, expected
addon-install-failed-notification
I guess gavin was right and the test here wasn't sound enough :(
Blocks: 633571
Attached patch patch rev 1 — — Splinter Review 
Switching to polling to wait for the single notification seems to work. If I looped test_check_security 100 times I could normally see a single failure. With this change I can loop it 500 times and not see a single failure.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #512939 - Flags: review?(gavin.sharp)
Attachment #512939 - Flags: review?(gavin.sharp) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/ca8863ba339b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
No more test failures in the last couple of days. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [orange] fails in test_failed_security → fails in test_failed_security
You need to log in before you can comment on or make changes to this bug.