If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

T ListImpl<T,ListHelper>::removeAt() should update ref count of object that is being removed

RESOLVED FIXED

Status

Tamarin
Virtual Machine
P3
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ruchi Lohani, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
T ListImpl<T,ListHelper>::removeAt(uint32_t index) calls moveRange() to remove object in case the index was not the last element index and calls clearRange() in case the index is the last index. moveRange does not update ref count. removeAt should call clearRange before calling moveRange to update the refcount of the object that is getting removed.
(Reporter)

Comment 1

7 years ago
Created attachment 512977 [details] [diff] [review]
fix refcount of deleted object
Attachment #512977 - Flags: review?
(Reporter)

Updated

7 years ago
Attachment #512977 - Flags: review? → review?(stejohns)

Updated

7 years ago
Attachment #512977 - Flags: review?(stejohns) → review+

Comment 2

7 years ago
TR 5940:014190009320
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.