634826 - .htaccess file permissions are not set by checksetup.pl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Tom Dickson]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_6; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.102 Safari/534.13
Build Identifier: 

I used bzr switch / bzr up to move to 4.0; it moved .htaccess to another file and replaced it.

Unfortunately the replacement was owned by root:root and so Apache couldn't read it, blocking access to the site. I had to fix it manually with a chgrp; ./checkconfig.pl didn't notice.

Reproducible: Didn't try

Steps to Reproduce:
1. Upgrade to 4.0
2. Run ./checkconfig.pl; it says fixing permissions
3. But .htaccess can't be read by Apache
Actual Results:  
The .htaccess file had permissions of 0640 and was owned root:root, so Apache couldn't read it. localconfig had the $webservergroup = 'apache'; so it should have been able to realize the problem.

Expected Results:  
Since I ran ./checkconfig.pl as root, it had permissions to change .htaccess if needed; perhaps it didn't see it because it is a dotfile? 

It was not difficult to figure out why I was getting a 403 Forbidden, once I checked the logs, but it is a minor note that could be mentioned in the release notes, as BZR moving .htaccess to .htaccess.moved meant that the new .htaccess file was created with the default permissions.

Comment 1

[Frédéric Buclin]

It's checksetup.pl, not checkconfig.pl. ;)

I just tested locally, and checksetup.pl indeed doesn't fix permissions nor ownership for this file in Bugzilla 4.0 and 4.1. But it fixes them correctly in 3.4 and 3.6. So we regressed this. Marking as a blocker as it may prevent Bugzilla from running correctly. Thanks for catching that!

Comment 2

[Frédéric Buclin]

It looks like that all .htaccess files are fixed correctly, except bugzilla/.htaccess, probably because it's not listed in %htaccess in Bugzilla/Install/Filesystem.pm.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Frédéric Buclin]

Looks like we regressed this in bug 560733.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 513173 [details] [diff] [review]
patch, v1

Ah, ha, good catch! Right, I was expected file-creation to catch this, but of course, .htaccess isn't created, anymore.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Install/Filesystem.pm
Committed revision 7719.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Install/Filesystem.pm
Committed revision 7560.