Open
Bug 634827
Opened 13 years ago
Updated 2 years ago
don't set up selection listeners for controls other than text fields
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
NEW
People
(Reporter: surkov, Unassigned, Mentored)
References
(Blocks 3 open bugs)
Details
(Keywords: access, good-first-bug, perf)
Attachments
(1 file)
1.67 KB,
patch
|
Details | Diff | Splinter Review |
We need to set up selection listeners for controls that has own selection controller like text fields, other controls should be handled presshell selection controller (that is added when document accessible is created). However we need to unregister selection listener for text field controls when something else gets focused.
Reporter | ||
Updated•13 years ago
|
Whiteboard: [good first bug]
Reporter | ||
Updated•13 years ago
|
Blocks: caretsela11y
Updated•13 years ago
|
Whiteboard: [good first bug] → [good first bug][mentor=surkov.alexander@gmail.com]
Reporter | ||
Comment 1•13 years ago
|
||
nsCaretAccessible manages the selection listeners (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsCaretAccessible.cpp), see SetControlSelectionListener and ClearControlSelectionListener methods. FocusManager class (FocusManager.cpp in same folder) manages the accessible focus and set selection listeners for control when control gets focused. So FocusManager should take care to remove current selection listener. Please don't hesitate to ask questions.
Assignee: nobody → brijesh3105
Updated•11 years ago
|
Assignee: brijesh3105 → nobody
Comment 2•10 years ago
|
||
hi alexander, i would like to take up this bug and work on it. can you please help me out?
Reporter | ||
Comment 3•10 years ago
|
||
basically I need to update on comment #1: you need to fix SelectionManager class (SetControlSelectionListener and ClearControlSelectionListener methods) to make it check weather the frame object has NS_FRAME_INDEPENDENT_SELECTION state. If it doesn't then return early. That's it.
Updated•10 years ago
|
Assignee: nobody → singh.kushagra93
Comment 4•10 years ago
|
||
Hi, Kushagra - Are you still working on this?
Flags: needinfo?(singh.kushagra93)
Comment 5•10 years ago
|
||
Hi Mike, I am really sorry. Totally forgot about this bug, will take it up after the weekend if that is fine with you?
Flags: needinfo?(singh.kushagra93) → needinfo?(mhoye)
Comment 7•10 years ago
|
||
Hope the patch is somewhat on the mark. Can you also please help me out with C++ debugging for the mozilla code. Thanks :)
Attachment #8433366 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8433366 [details] [diff] [review] Initial patch. Review of attachment 8433366 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/base/SelectionManager.cpp @@ +38,5 @@ > > void > SelectionManager::ClearControlSelectionListener() > { > + if (!mCurrCtrlFrame || mCurrCtrlFrame->NS_FRAME_INDEPENDENT_SELECTION == NULL) I think the idea should work but you didn't build it and run automated test suite, right? It looks like you should use GetStates()
Attachment #8433366 -
Flags: review?(surkov.alexander)
Assignee | ||
Updated•10 years ago
|
Mentor: surkov.alexander
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com] → [good first bug]
Comment 9•9 years ago
|
||
Hi Alexander, I would like work on this bug. Can you please assign me to it?
Reporter | ||
Comment 10•9 years ago
|
||
Let's check if Kushagra works on it
Flags: needinfo?(singh.kushagra93)
Comment 11•9 years ago
|
||
Sorry, I won't be able to work on it. Assigning it to Kevin.
Flags: needinfo?(singh.kushagra93)
Updated•9 years ago
|
Assignee: singh.kushagra93 → kmather73
Updated•4 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug]
Comment 12•3 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Assignee: kmather73 → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•