Remove old platforms from tamarin buildbot

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Assigned: James Sudduth)

Tracking

unspecified
Bug Flags:
flashplayer-injection -
flashplayer-qrb +
flashplayer-bug -
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(6 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
The following build slaves will be removed from the tamarin build system:
* PPC - Mac OS X 10.4 and 10.5 32bit & 64bit
* Intel - Mac OS X 10.4
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-bug-

Comment 1

7 years ago
Is there still a WinCE (or, gasp, Symbian) in the system? If so, we should nuke those as well.
(Reporter)

Comment 2

7 years ago
WinCE is still being compiled in the deep phase and will be added to the list of things to remove, buildbot is not and has not done anything for Symbian.

To be clear, this is ONLY to track the removal of these platforms from buildbot and will NOT touch any source code (#ifdef block removal)

* PPC - Mac OS X 10.4 and 10.5 32bit & 64bit
* Intel - Mac OS X 10.4
* WinCE

Comment 3

7 years ago
Right, but it will easier to remove the dead source code once the builder no longer relies on it...
(Reporter)

Updated

7 years ago
Assignee: nobody → brbaker
(Reporter)

Comment 4

7 years ago
Created attachment 513180 [details] [diff] [review]
Remove platforms from buildbot

This patch removes information about the following platforms from the buildbot configuration. 
- PPC Mac OS X
- Intel Mac OS X 10.4
- WinCE
Attachment #513180 - Flags: review?(cpeyer)
(Reporter)

Comment 5

7 years ago
Created attachment 513182 [details] [diff] [review]
Remove build scripts

Remove build scripts that were used on the following platforms:

- PPC Mac OS X
- Intel Mac OS X 10.4
- WinCE
Attachment #513182 - Flags: review?(cpeyer)
(Reporter)

Comment 6

7 years ago
Created attachment 513183 [details] [diff] [review]
Missed removal of slaves/all/avmshell-arm-setup.sh

slaves/all/avmshell-arm-setup.sh: this is an old script that was used to deploy the avmshell via ActiveSync for WinCE
Attachment #513183 - Flags: review?(cpeyer)
(Reporter)

Comment 7

7 years ago
Is there any real business need for us to maintain a build slave that is running specifically on a P3 cpu? We currently run acceptance on windowsXP on an old P3 machine. I would like to retire that hardware out of the build system.

Comment 8

7 years ago
Not that I can think of.

Updated

7 years ago
Attachment #513180 - Flags: review?(cpeyer) → review+

Updated

7 years ago
Attachment #513182 - Flags: review?(cpeyer) → review+

Updated

7 years ago
Attachment #513183 - Flags: review?(cpeyer) → review+

Comment 9

7 years ago
changeset: 5942:f94bc372499f
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: remove PPC, Mac OS X 10.4 and WinCE from the buildbot config. Also switch the 10.5 32bit shell to compile with the 105 SDK (r=cpeyer)

http://hg.mozilla.org/tamarin-redux/rev/f94bc372499f

Comment 10

7 years ago
changeset: 5943:bd2cedeecef9
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: remove build scripts that were used for the following platforms:  PPC, Mac OS X 10.4 and WinCE (r=cpeyer)

http://hg.mozilla.org/tamarin-redux/rev/bd2cedeecef9
(Reporter)

Comment 11

7 years ago
Created attachment 513434 [details] [diff] [review]
Remove P3 build slave

This removes the windows-P3 build slave from buildbot.

I also reordered the definition and display of the deep build slaves to keep the platforms together in the display and also to have the definition of the builders in the configuration match the order in which they are displayed. If this causes too much issue looking at the patch let me know and I can break this into 2 patches.
Attachment #513434 - Flags: review?(cpeyer)

Comment 12

7 years ago
changeset: 5956:0da2209460fa
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: remove unusde mac-intel-10.4 buildbot scripts (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/0da2209460fa

Comment 13

7 years ago
Have the changes to remove WinCE landed? (If so, I'll proceed with removing dead code)
(Reporter)

Comment 14

7 years ago
(In reply to comment #13)
> Have the changes to remove WinCE landed? (If so, I'll proceed with removing
> dead code)

Yes WinCE is no longer in the buildbot configuration.

Only patch that has not landed that is on this bug is the removal of the P3 build slave.
(Reporter)

Comment 15

7 years ago
Created attachment 517721 [details] [diff] [review]
Remove SH4 from buildbot

Remove the SH4 slave and the linux builder that only compiled the SH4 binary
Attachment #517721 - Flags: review?(dschaffe)
(Reporter)

Updated

7 years ago
Status: NEW → ASSIGNED

Updated

7 years ago
Attachment #517721 - Flags: review?(dschaffe) → review+

Comment 16

7 years ago
changeset: 6050:b2a7f3b322ca
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: Remove the SH4 buildslave from buildbot, also remove dedicated linux2 buildslave that used to only compile the SH4 binary (r=dschaffe)

http://hg.mozilla.org/tamarin-redux/rev/b2a7f3b322ca

Updated

7 years ago
Flags: flashplayer-qrb? → flashplayer-qrb+

Updated

7 years ago
Attachment #513434 - Flags: review?(cpeyer)
(Reporter)

Comment 17

7 years ago
Created attachment 522959 [details] [diff] [review]
Replace win64 slave with new hardware
Attachment #522959 - Flags: review?(dschaffe)

Comment 18

7 years ago
changeset: 6138:ec7f2eb4b2c4
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: replace win64 build slave with new hardware

http://hg.mozilla.org/tamarin-redux/rev/ec7f2eb4b2c4

Comment 19

7 years ago
changeset: 6139:a7a454c32fe8
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 634957: need to at least pass a 'space' to the compile step if no args are to be passed to configure.py, I had removed --enable-shell since it now defaults to true so we don't need to pass it (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/a7a454c32fe8
(Reporter)

Updated

7 years ago
Attachment #522959 - Flags: review?(dschaffe)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 20

7 years ago
trbaker: We are still building and testing on a P3 class machine. Should this be removed from the build?

Comment 21

7 years ago
Jim, please remove the p3 machine as well.  Thanks.
Assignee: brbaker → jsudduth
Status: RESOLVED → REOPENED
Flags: flashplayer-injection-
Resolution: FIXED → ---
(Assignee)

Comment 22

7 years ago
Created attachment 528731 [details] [diff] [review]
Remove windows-p3-deep build slave.

This is a refreshed patch to replace patch 513434, which wasn't ever pushed and wouldn't apply on my machine. Also, there have been other changes to tamarinredux.py that made it seem like a good idea to make a new patch. 

This patch removes the windows p3 build slave. Like the patch it replaces it also:
1. reorders the display list of deep builders on the waterfall page
2. arranges the list of deep builders in tamarinredux.py to match the waterfall page order
3. removes the /windows-p3-deep files (buildbot.tac and environment.sh) from /build/buildbot/slaves
Attachment #513434 - Attachment is obsolete: true
Attachment #528731 - Flags: review?(brbaker)
(Reporter)

Comment 23

7 years ago
Comment on attachment 528731 [details] [diff] [review]
Remove windows-p3-deep build slave.

Review of attachment 528731 [details] [diff] [review]:

::: build/buildbot/master/public_html/announce.html
@@ +117,4 @@
                         var compile = "builder=windows-compile&builder=windows64-compile&builder=mac-intel-10.5-compile&builder=mac64-intel-compile&builder=linux-compile&builder=linux64-compile&builder=solaris-sparc-compile&builder=android-compile&builder=linux-arm-compile&builder=linux-mips-compile"
                         var smoke = "builder=windows-smoke&builder=windows64-smoke&builder=mac-intel-10.5-smoke&builder=mac64-intel-smoke&builder=linux-smoke&builder=linux64-smoke&builder=solaris-sparc-smoke&builder=android-smoke&builder=linux-arm-smoke&builder=linux-mips-smoke"
                         var test = "builder=windows-test&builder=windows64-test&builder=mac-intel-10.5-test&builder=mac64-intel-test&builder=linux-test&builder=linux64-test&builder=solaris-sparc-test&builder=android-test&builder=linux-arm-test&builder=linux-mips-test"
+                        var deep = "builder=windows-deep&builder=windows64-deep&builder=mac-deep&builder=mac64-deep&builder=solaris-sparc-deep&builder=solaris-sparc2-deep&builder=linux-deep&builder=linux-arm-deep&builder=linux-mips-deep&builder=windows-frr"

shouldn't the solaris builders be right before the windows-frr slave? (matching the order in the tamarinredux.py)
Attachment #528731 - Flags: review?(brbaker) → review+
(Assignee)

Comment 24

7 years ago
Created attachment 528869 [details] [diff] [review]
Moves the sparc deep builders in announce.html to just before windows-frr.

Good catch!
Attachment #528731 - Attachment is obsolete: true
Attachment #528869 - Flags: review+

Comment 25

7 years ago
changeset: 6245:2213ea5efda6
user:      James Sudduth <jsudduth@adobe.com>
summary:   Bug 634957 - Remove old platforms from tamarin buildbot (windows-p3-deep) (r-brbaker)

http://hg.mozilla.org/tamarin-redux/rev/2213ea5efda6
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.