JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: imphil, Assigned: imphil)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 513175 [details] [diff] [review]
patch v1

I get the warning message:

JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value

A patch is attached. If I'm not mistaken the return is ignored anyway. I guess the idea was to exit from the each-loop, but the implementation of each in iQ seems to have no way to do this.

(this was added in bug 600645)
Attachment #513175 - Flags: review?(ian)
Comment on attachment 513175 [details] [diff] [review]
patch v1

Good point!

I've filed a follow-up: bug 635311
Attachment #513175 - Flags: review?(ian) → review+
Blocks: 627096
(Assignee)

Comment 2

7 years ago
Comment on attachment 513175 [details] [diff] [review]
patch v1

No real risk and no functional change, but it makes debug builds output less useless warnings and by that real problems easier to find.
Attachment #513175 - Flags: approval2.0?
Assignee: nobody → mail
Status: NEW → ASSIGNED
Comment on attachment 513175 [details] [diff] [review]
patch v1

a=beltzner
Attachment #513175 - Flags: approval2.0? → approval2.0+
Created attachment 514284 [details] [diff] [review]
Patch for checkin
Attachment #513175 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/27ab44a83e3e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.