Closed Bug 634974 Opened 10 years ago Closed 10 years ago

JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: imphil, Assigned: imphil)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v1 (obsolete) — Splinter Review
I get the warning message:

JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value

A patch is attached. If I'm not mistaken the return is ignored anyway. I guess the idea was to exit from the each-loop, but the implementation of each in iQ seems to have no way to do this.

(this was added in bug 600645)
Attachment #513175 - Flags: review?(ian)
Comment on attachment 513175 [details] [diff] [review]
patch v1

Good point!

I've filed a follow-up: bug 635311
Attachment #513175 - Flags: review?(ian) → review+
Blocks: 627096
Comment on attachment 513175 [details] [diff] [review]
patch v1

No real risk and no functional change, but it makes debug builds output less useless warnings and by that real problems easier to find.
Attachment #513175 - Flags: approval2.0?
Assignee: nobody → mail
Status: NEW → ASSIGNED
Comment on attachment 513175 [details] [diff] [review]
patch v1

a=beltzner
Attachment #513175 - Flags: approval2.0? → approval2.0+
Attachment #513175 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/27ab44a83e3e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.