635044 - Block layers acceleration and Direct2D on NVIDIA NVS 3100M on driver 8.17.12.5896

Status: RESOLVED FIXED

(Toolkit :: Blocklist Policy Requests, defect)

Description

[Joe Drew (not getting mail)]

First question - we won't send gfxItems blocklist entries to non-4.0 Firefoxes, right? I'm not sure how the blocklist in previous Firefoxes behaves if it gets things it doesn't understand. (Mossop might be able to comment on this.) There's no upside to sending it to 3.x, regardless, though.

My SQL is pretty rusty. In particular, I don't know what specifying a number for the auto_increment primary key does, but I've specified different numbers there anyways.

Les tells me that the GUID here is the Firefox product GUID, so I'm leaving it as-is.

INSERT INTO `blgfxdrivers` (9, '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}', 'WINNT 6.1', '0x10de', '0x0a6c', 'DIRECT2D', 'BLOCKED_DRIVER_VERSION', '8.17.12.5896', 'LESS_THAN_OR_EQUAL', '0000-00-00 00:00:00','0000-00-00 00:00:00')
INSERT INTO `blgfxdrivers` (10, '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}', 'WINNT 6.1', '0x10de', '0x0a6c', 'DIRECT3D_9_LAYERS', 'BLOCKED_DRIVER_VERSION', '8.17.12.5896', 'LESS_THAN_OR_EQUAL', '0000-00-00 00:00:00','0000-00-00 00:00:00')

Comment 1

[Matthias Versen [:Matti]]

Don't forget Seamonkey :-)

Comment 2

[Justin Scott [:fligtar]]

Hi Joe,

A couple comments/questions:

1. Can you add more details about why this block is warranted? (I'm sure it is if you're asking for it, it's just that we need that information for all blocks)

2. Does this need to happen before Firefox 4? If so, please ask for blocking status because we have too many hardblockers and softblockers in Blocklisting right now for me to spend time on others.

3. auto_increment values should be NULL and created and modified should be NOW()

4. if you omit the app GUID, does it apply to all apps? That's the way other parts of blocklist work and would be nice to not have separate Firefox/SeaMonkey entries if possible.

Comment 3

[Joe Drew (not getting mail)]

This needs to hardblock and happen before or near Firefox 4 beta 12, because it's the first live test of graphics blacklisting.

We need to block this driver combination because it's the latest version Lenovo makes available, and yet using hardware-accelerated Firefox still crashes the graphics driver multiple times per day. We believe that if Lenovo updates the driver this problem will go away, because Stuart has a non-standard NVIDIA driver for this machine which is newer than the Lenovo driver, and it hasn't crashed recently.

This should apply to all apps, yes.

Here's the updated SQL:

INSERT INTO `blgfxdrivers` (NULL, NULL, 'WINNT 6.1', '0x10de', '0x0a6c', 'DIRECT2D', 'BLOCKED_DRIVER_VERSION', '8.17.12.5896', 'LESS_THAN_OR_EQUAL', NOW(), NOW())

INSERT INTO `blgfxdrivers` (NULL, NULL, 'WINNT 6.1', '0x10de', '0x0a6c', 'DIRECT3D_9_LAYERS', 'BLOCKED_DRIVER_VERSION', '8.17.12.5896', 'LESS_THAN_OR_EQUAL', NOW(), NOW())

Comment 4

[Justin Scott [:fligtar]]

Okay, this is on our staging server as:
  <gfxBlacklistEntry>
    <os>WINNT 6.1</os>
    <vendor>0x10de</vendor>
    <devices>
      <device>0x0a6c</device>
    </devices>
    <feature>DIRECT2D</feature>
    <featureStatus>BLOCKED_DRIVER_VERSION</featureStatus>
    <driverVersion>8.17.12.5896</driverVersion>
    <driverVersionComparator>LESS_THAN_OR_EQUAL</driverVersionComparator>
  </gfxBlacklistEntry>
  <gfxBlacklistEntry>
    <os>WINNT 6.1</os>
    <vendor>0x10de</vendor>
    <devices>
      <device>0x0a6c</device>
    </devices>
    <feature>DIRECT3D_9_LAYERS</feature>
    <featureStatus>BLOCKED_DRIVER_VERSION</featureStatus>
    <driverVersion>8.17.12.5896</driverVersion>
    <driverVersionComparator>LESS_THAN_OR_EQUAL</driverVersionComparator>
  </gfxBlacklistEntry>

Please test that it works using these instructions: https://wiki.mozilla.org/Blocklisting/Testing

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Joe: who's gonna own the testing and verification, here?

Comment 6

[Ed Morley [:emorley]]

(In reply to comment #4)
> Please test that it works using these instructions:
> https://wiki.mozilla.org/Blocklisting/Testing
Btw the instructions there omit to state that the user should be searching/editing extensions.blocklist.url, in step 1. I don't have a mozilla wiki account or I'd try to correct it.

Comment 7

[juan becerra [:juanb]]

We filed a ticket to source a machine with the specs listed here, but Joe is going to look at testing this as well.

Comment 8

[Joe Drew (not getting mail)]

OK! Hooray, this works while spoofing! We'll wait for QA to test in a real computer, but this looks good to go.

Comment 9

[Joe Drew (not getting mail)]

Beta 12 doesn't need to wait for QA verification on this. We also don't need to hold beta 12 for this to be pushed live. However, it does need to be pushed live during beta 12 (and significantly before RC), so QA can verify with their new hardware and we can handle any bugs they find.

Note to QA for verification: There is no notification that your graphics hardware has been blacklisted, and the blacklist doesn't take effect until you restart Firefox. Once Firefox has completed a blocklist ping, you can restart Firefox and look at the graphics section in about:support. You should see a) Direct2D and DirectWrite turned off; b) "Blocked on your hardware due to unresolved driver issues" or something to that effect; and c) 0 hardware accelerated windows.

Comment 10

[Scoobidiver (away)]

With this bug, the graphic driver version D2D/D3D blocklisting will be managed in two ways:
1. some will be D2D/D3D-blocklist through add-ons blocklisting (user is informed by a popup, easy to maintain).
2. others will be D2D/D3D-blocklist through code blocklisting (user is only informed by http://www.mozilla.com/en-US/firefox/system-requirements.html, which is hard to build for Firefox 4, see bug 601079).

Could it be possible to D2D/D3D-blocklist graphic drivers only with solution 1?
Which website is going to be updated whatever the retained solution? http://www.mozilla.com/en-US/firefox/system-requirements.html or https://www.mozilla.com/en-US/blocklist?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Fligtar: can we just make with the pushy-push?

Comment 12

[Justin Scott [:fligtar]]

(In reply to comment #11)
> Fligtar: can we just make with the pushy-push?

I was waiting for beta 12 per Joe's comment. If that's not necessary I can push it now, yes.

Comment 13

[Joe Drew (not getting mail)]

Sorry, I was unclear. This needs to go live *at latest* early in the beta 12 period. Any time up to then is fine.

Comment 14

[Justin Scott [:fligtar]]

Filed bug 636254 to run the SQL (we don't have an admin tool for gfx blocking yet).

Joe, can you start this wiki page listing blocked drivers, versions, features, why, etc.? https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers

Thanks

Comment 15

[juan becerra [:juanb]]

Attachment: before and after test

Got the hardware today and tested using instructions from comment #6 and the wiki. It looks like it is working in the testing environment. We'll check once again when it goes live.

Comment 16

[Joe Drew (not getting mail)]

(In reply to comment #14)
> Joe, can you start this wiki page listing blocked drivers, versions, features,
> why, etc.? https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers

Done!

Comment 17

[Justin Scott [:fligtar]]

Blocked in production. Will take a little for cache to clear.

Comment 18

[Joe Drew (not getting mail)]

Did this get reverted in production? This worked at first, but now even repeated blocklist pings return no gfxItems.

Comment 19

[Justin Scott [:fligtar]]

Turns out our admin tool for gfx blocks had a bug; this is back to waiting on SQL to be run, but I will make sure that happens today.

Comment 20

[Justin Scott [:fligtar]]

Hooray, this is fixed for real.

Comment 21

[Marcia Knous [:marcia]]

Verified fixed using  Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12) Gecko/20100101 Firefox/4.0b12. Removing QA wanted keyword.

I verified that I get what Joe listed in Comment 9.

Comment 22

[Shyam Mani [:fox2mike]]

Reopen by Kyle because this caused breakage on mozilla-central

Comment 23

[Damon Sicore (:damons)]

Curious.  What exactly did this break in m-c?

Comment 24

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #23)
> Curious.  What exactly did this break in m-c?

https://bugzilla.mozilla.org/show_bug.cgi?id=637008#c9

Comment 25

[Damon Sicore (:damons)]

OK.  We're done with bug 637413.  What's next here?

Comment 26

[Joe Drew (not getting mail)]

Nothing!

Comment 27

[Allie S]

I have NVIDIA NVS 3100M driver version 8.17.12.7593 installed on my thinkpad T410.  Firefox is still saying that WebGL is blocked due to driver incompatibility.  WebGL should be working, since my driver > 8.17.12.5896, right?  Any idea what might be going on here?

Comment 28

[Allie S]

(In reply to Allie S from comment #27)
> I have NVIDIA NVS 3100M driver version 8.17.12.7593 installed on my thinkpad
> T410.  Firefox is still saying that WebGL is blocked due to driver
> incompatibility.  WebGL should be working, since my driver > 8.17.12.5896,
> right?  Any idea what might be going on here?

Specifically, FF about:support says: WebGL Renderer - Blocked for your graphics card because of unresolved driver issues.

Comment 29

[Benoit Jacob [:bjacob] (mostly away)]

Please go to about:config, reset all your gfx.blacklist.* preferences, retry.

Firefox currently only updates this once per day. See bug 653102.

Comment 30

[Allie S]

Thanks Benoit.  I'll post back if I start getting crashes or other problems, but i'm sure it's all ok.

Comment 31

[Allie S]

Benoit: this issue seems to have reared it's head again with FF 12.  I can't find any gfx.blacklist.* prefs, and bug 653102 seems to make mention of that.  How do I go about fixing this issue now - any ideas?  thanks.

Comment 32

[Benoit Jacob [:bjacob] (mostly away)]

Is your system dual-GPU? I.e. with a NVIDIA and a Intel GPU? If yes, sorry, you may be running into the limitations of our gpu detection code. The only solution for now, then, would be to force-enable. We do need to prioritize work on this.

Comment 33

[Allie S]

Hi Benoit,

I do have a dual-GPU (NVIDIA NVS 3100M / Intel HD GM55) on my thinkpad T410.  However, for some reason, opengl now seems to be working on it after updating my video drivers.  Not sure why all the erratic behavior, but things seem to be working in my case at the moment.