635129 - Django app has no page for 403 Forbidden errors

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[Les Orchard [:lorchard]]

Some actions result in a 403 Forbidden error, such as attempting to delete a demo not owned by the user or by a non-admin user. But, there's no styled page for this error and Django doesn't seem to support this without adding middleware like this:

https://github.com/wtanaka/django403

Comment 1

[Jay Patel [:jay]]

I would like to try to get something up for 0.9.4.  Now that we will have more users playing with UGC, we should handle cases like this with as much useful info as possible.

I can help work on the copy and hopefully adding a page for 403 isn't too difficult to do.

Comment 2

[Luke Crouch [:groovecoder]]

I threw a page together for now. Log out of developer-stage9 and then go to https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/delete to see it.

Jay, let's work out the copy we want.

Comment 3

[Jay Patel [:jay]]

Adding Sheppy and Janet for some copy help.

I can't seem to come up with anything better than what Luke already put on that page.

I've never written custom 403 or 404 pages... is it acceptable to create a mini sitemap and have a big promo to become a member at the top?   

At the very least, we should at least present the following to the user:

1. Are you logged in as the right user? (already there)
2. If not, please sign up for the Mozilla Developer Network! (and add some cool things you can do as a member:  contribute to docs, submit demos, talk about technology, etc)
3. There are a lot you can do without an account too! (link to doc center and demo studio so they can at least explore content that doesn't require login)

Does that make sense to have on a 403 page?

Comment 4

[Luke Crouch [:groovecoder]]

I was about to say that sounds like too much for a humble 403 page, but I personally think a company's personality can show really well in the way it writes its error pages. It'd be cool to write a playful/teasing tone on the 403 page. "Silly developer, that's not YOUR demo!" ;)

Comment 5

[Janet Swisher]

Instead of "permission denied", how about a nod to HAL 9000: 

I'm sorry. I'm afraid I can't let you do that.

("I'm sorry, Dave" would be more authentic but also more confusing.
I'm not sure this is a good place to go all salesy, but a little tongue-in-cheek would be OK.)

Are you sure you're [logged in] as the right user?
You do [have an account], don't you? You need one in order to edit docs, submit demos, and post to forums.
If not, you can still [view demos] and [browse documentation].

I'm completely operational and all my circuits are functioning perfectly. However, if you think this is an error, please [file a bug]. Thank you.

Comment 6

[Luke Crouch [:groovecoder]]

brilliant! I'll see if I can throw the current username into the line.

Comment 7

[Luke Crouch [:groovecoder]]

Attachment: GLaDOS 403

I like this GLaDOS version more. :)

Comment 8

[Luke Crouch [:groovecoder]]

Attachment: HAL 403

Comment 9

[Jay Patel [:jay]]

Let's go with the HAL 403.  It doesn't sound as scary and will probably make more sense to the majority of visitors. 

No idea how the l10n community will react, but hopefully 2001 is something most of the world is familiar with.

Comment 10

[raymond [:retornam] (inactive)]

qa-verified-stage https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/404

Comment 11

[Jay Patel [:jay]]

Comment on attachment 523626 [details]
HAL 403

It'll be cool if we can find a way to insert the username based on cookie info... but even if not, I think this will work well.

Thanks Janet for the idea and Luke for the quick patch.

Comment 12

[Jay Patel [:jay]]

Comment on attachment 523625 [details]
GLaDOS 403

I'm not familiar with GLaDOS, so the language and personality for this version doesn't seem as cool as the HAL version.  But that's just me...

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #10)
> qa-verified-stage
> https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/404

What are you verifying?  There's still a pending patch, and the bug is "Assigned".

Comment 14

[Jay Patel [:jay]]

Raymond:  Thanks for verifying that the 403 is in place and working, but please wait until we have the new copy checked in before signing off.

Luke will mark this resolved fixed when it's ready for QA.

Comment 15

[raymond [:retornam] (inactive)]

(In reply to comment #14)
> Raymond:  Thanks for verifying that the 403 is in place and working, but please
> wait until we have the new copy checked in before signing off.
> 
> Luke will mark this resolved fixed when it's ready for QA.

The bug was marked qa-wanted so I verified on trunk. Please mark bugs as qa-wanted only after it is done.

Comment 16

[Luke Crouch [:groovecoder]]

Sorry, I had qa-wanted on there before we started adjusting the copy. HAL copy added to mdn and kuma repositories. Jay: if the user is logged-in it does say "I'm sorry {{username}}, ..." ;)

Comment 17

[raymond [:retornam] (inactive)]

(In reply to comment #16)
> Sorry, I had qa-wanted on there before we started adjusting the copy. HAL copy
> added to mdn and kuma repositories. Jay: if the user is logged-in it does say
> "I'm sorry {{username}}, ..." ;)

https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/404

When user is  logged in it says

I'm sorry, I could not find what you were looking for.

Please start over on the home page.

If you were following a broken link, please file a bug. Thanks!

Comment 18

[Les Orchard [:lorchard]]

(In reply to comment #17)
> assigned_to: [e-mail] => [e-mail]; whiteboard: qa-wanted => (In reply to comment #16)
> > Sorry, I had qa-wanted on there before we started adjusting the copy. HAL copy
> > added to mdn and kuma repositories. Jay: if the user is logged-in it does say
> > "I'm sorry {{username}}, ..." ;)
> 
> https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/404

FWIW, that's a 404 Not Found, not a 403 Forbidden.

This should give a 403 (unless you're mcoates):
https://developer-stage.mozilla.org/en-US/demos/detail/this-is-a-test/delete

Comment 19

[raymond [:retornam] (inactive)]

(In reply to comment #18)
> (In reply to comment #17)
> > assigned_to: [e-mail] => [e-mail]; whiteboard: qa-wanted => (In reply to comment #16)
> > > Sorry, I had qa-wanted on there before we started adjusting the copy. HAL copy
> > > added to mdn and kuma repositories. Jay: if the user is logged-in it does say
> > > "I'm sorry {{username}}, ..." ;)
> > 
> > https://developer-stage9.mozilla.org/en-US/demos/detail/flight-of-the-navigator/404
> 
> FWIW, that's a 404 Not Found, not a 403 Forbidden.
> 
> This should give a 403 (unless you're mcoates):
> https://developer-stage.mozilla.org/en-US/demos/detail/this-is-a-test/delete

Thanks for the correction,
https://developer-stage.mozilla.org/en-US/demos/detail/this-is-a-test/delete

Comment 20

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/demos/detail/this-is-a-test/delete