635294 - Add Milestone2 efforts to Identity Server

Status: RESOLVED FIXED

(Cloud Services :: Server: Identity, defect)

Description

[JR Conlin [:jrconlin,:jconlin]]

Add:
 SQL Storage Back-end for user and association
 generate site-id & secret per milestone objectives
 Add JSON response (with worker JS callback) to success page.
 Rough in login, account manager page

Comment 1

[JR Conlin [:jrconlin,:jconlin]]

NOTE: SQL storage has been OBE by a mongo db.

Comment 2

[JR Conlin [:jrconlin,:jconlin]]

Attachment: M2 content

NOTE: MySQL store has been Overcome By Events and replaced with a Mongo data store. Some elements (such as Terms) have not yet been finalized, but templates have been created. See the diff header for a list of the new functions.

Comment 3

[JR Conlin [:jrconlin,:jconlin]]

Attachment: second round fixes for m2

Added terms

Comment 4

[Toby Elliott [:telliott]]

Comment on attachment 528234 [details] [diff] [review]
second round fixes for m2

Looks good for the most part. Some notes:

main controller:

282/3: I think the nested if is unnecessary, and you can grab the email during the if conditional (or at least use if 'email' in...)

same on 329-332, which could probably be streamlined to be clearer

333: Is this comment still relevant here? Looks extraneous

340: exception is raised and logged, then passes. Intentional? You used to throw a bad request here, and you're sending who knows what into get_uid.

530: There's a path here with a number in it. Should be a constant somewhere?

mongo.py:

320: I think this is using the old exception style rather than Exception, e. Don't look at me, I prefer the old way too.

in various mako templates: is admin_url safe? There's a user generated component in here.

user.mako 57/8. These two variables are unescaped and are scary enough that it's worth checking whether we shouldn't be |h here.

Otherwise, looking pretty reasonable.

Comment 5

[JR Conlin [:jrconlin,:jconlin]]

committed 63:f88c52e0d0aa