RestArgAnalyzer breaks continuity of Coder pipeline

RESOLVED FIXED

Status

Tamarin
Baseline JIT (CodegenLIR)
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: William Maddox, Assigned: William Maddox)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 513638 [details] [diff] [review]
Always pass writeOpcodeVerified() calls through the pipeline

The patch for 569321 introduced an optional pipeline stage RestArgAnalyzer.
Its apparent purpose is to intercept writes of certain opcodes from the verifier in order to perform a conservative escape analysis on rest arguments.  The usual expectation is that handlers overridden in a pipeline stage should eventually delegate to the like-named handler in the following stage, and that is mostly observed here.  However, if the analysis has failed (e.g., a possible escape is detected), we exit RestArgAnalyzer::writeOpcodeVerified() prior to such delegation.
(Assignee)

Updated

8 years ago
Attachment #513638 - Attachment is patch: true
Attachment #513638 - Flags: review?(lhansen)

Updated

8 years ago
Attachment #513638 - Flags: review?(lhansen) → review+

Comment 1

8 years ago
changeset: 5963:b581a98b6f60
user:      William Maddox <wmaddox@adobe.com>
summary:   Bug 635422 - Always pass calls through the pipeline in RestArgAnalyzer::writeOpcodeVerified() (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/b581a98b6f60
(Assignee)

Updated

8 years ago
Assignee: nobody → wmaddox
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.